SciKit-Surgery / scikit-surgery

SciKit-Surgery - Compact Libraries for Surgical Navigation
http://scikit-surgery.github.io/scikit-surgery/
Other
38 stars 11 forks source link

Build failing for scikit-surgery #67

Closed mianasbat closed 3 years ago

mianasbat commented 3 years ago

It seems that the build is failing for master branch of project scikit-surgery (https://github.com/UCL/scikit-surgery) . Is it because of the migration issues?

@tdowrick @thompson318 @MattClarkson

mianasbat commented 3 years ago

The test log shows error No file or directory present on line 44 in test_docs_complete.py. I was exploring it and I found that os.listdir() is given relative path. I gave it absolute path i.e. /Users/mianasbatahmad/temp/scikit-surgery/modules and that specific error disappeared. I also found that os.listdir() is not very comfortable with relative path as discussed on https://bit.ly/2ZP838u I am checking it more. Open for any hints, suggestions!

mianasbat commented 3 years ago

Tom and I looked it this morning and that was very helpful. So one reason the tests were failing on my computer was that my modules directory contained .DS_Store directory and the code was looking for docs in all directories inside module directory. We added code to only consider directories starting with scikit- to fix it.

Secondly the submodules are empty directories (linked to respective repose) because I used git clone scikit-surgery when I should have used git clone --recursive scikit-surgery to download the submodules too as pointed by Tom. After this the file not found error should go away (ideally)

https://stackoverflow.com/questions/3796927/how-to-git-clone-including-submodules

We will need to figure out how to manage it in online testing.

MattClarkson commented 3 years ago

Discussed 22/10/2020:

tdowrick commented 3 years ago

Closed by #74