search

SciKit-Surgery / scikit-surgery

SciKit-Surgery - Compact Libraries for Surgical Navigation
http://scikit-surgery.github.io/scikit-surgery/
Other
38 stars 11 forks source link

ROS Examples #83

Closed tdowrick closed 3 years ago

tdowrick commented 3 years ago

@MattClarkson @thompson318 @mianasbat

tdowrick commented 3 years ago

I've made a start on this, but it seems that ROS only officialy support Python 2.7. It is possible to configure it for Python 3, but it is somewhat involved and I don't think we could assume that a user would be able to do it for the purposes of a tutorial.

Some of the packages will work with Python 2.7, but tensorflow/torch etc, or any of the C++ built libraries would probably cause some issues.

thompson318 commented 3 years ago

surgery-nditracker should work with py27. So could so a basic tracking source. Though is ros already has nodes for ndi I'm not sure who'd use it.

tdowrick commented 3 years ago

ROS 2.0 does support Python 3, but my (limited) understanding is that ROS 1 is still the more widely used version.

However, for the purposes of give some brief examples of how scikit-surgery can work with ROS, using 2.0 is probably fine, especially if we can then show features that we can't if we are limited to Python 2.7.

thompson318 commented 3 years ago

I agree it makes sense to use ROS 2.0.

tdowrick commented 3 years ago

I've added a little chessboard detection example/tutorial to demonstrate compatibility with ROS2, which I've also added to the list of tutorials on the main page.

https://scikit-surgery.readthedocs.io/en/latest/ros.html

tdowrick commented 3 years ago

Closing, as we have one example up. Can create new issues if there are specific things to implement.