search

SciKit-Surgery / scikit-surgerybard

BARD: The Basic Augmented Reality Demo, used at MedICSS summer school.
https://scikit-surgerybard.readthedocs.io/
Other
7 stars 3 forks source link

Fix and tidy up bardCameraCalibration #11

Closed thompson318 closed 4 years ago

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 19, 2019, 16:26

Essential: return -s command line option. It looks to me like the object points have a 1 mm spacing. Which is going to give us bad calibration in most cases.

Nice: It would be nice to have some verbose out put, and some writing out out of annotated images, so we can have a discussion of what's going on.

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 19, 2019, 16:30

Also consider output format, at the moment it's duplicated (triplicated with stdout). What can we out put to explain rms error.

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 19, 2019, 16:46

A snappy calibration tool kit (inspired by matlab) could be useful, and could then be used for the IGS module.

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 19, 2019, 16:58

mentioned in commit 009286fc4d74a8bbaa9f6f43eb506fb70c62779e

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 26, 2019, 12:24

mentioned in commit 6d0fd46c31761b0ed3520dc3f24f8279aa17fe06

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 26, 2019, 12:24

mentioned in commit 57c568f332cceeae8df53f8d083d5b52f7290ecc

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 26, 2019, 12:24

mentioned in commit 5e4299c3d940c441fd5484599511b333cf084624

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 26, 2019, 12:24

mentioned in commit 5112dc62411974e33a77caa4586d636c1dba1546

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 26, 2019, 12:45

This is fixed. Interestingly, changing the grid size does not effect the result. It changes the estimate of tvecs, but we don't use these in this application.

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 26, 2019, 12:45

closed

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 26, 2019, 16:44

mentioned in commit a5453e0df587d774d4622d62e043152c7fcfaf2a