SciKit-Surgery / scikit-surgerybard

BARD: The Basic Augmented Reality Demo, used at MedICSS summer school.
https://scikit-surgerybard.readthedocs.io/
Other
7 stars 3 forks source link

Resolve "bardCameraCalibration also needs to get input via a json file" - [merged] #41

Closed thompson318 closed 4 years ago

thompson318 commented 4 years ago

In GitLab by @MianAhmad on Jul 8, 2019, 14:23

Merges 26-bardCameraCalibration-input-via-json -> master

Closes #26

This branch modifies calibration process so that it takes input via a configuration file.
The following command (1) will be replaced by command (2) to do the calibration.

(1)
python bardCameraCalibration.py  --xcorners 14 --ycorners 10 --size 24 -i <output_dir> --verbose

(2)
python3 bardCameraCalibration.py --config config/calibration_input.json

I also updated the respective test cases and documentation related to the above change.

thompson318 commented 4 years ago

In GitLab by @MianAhmad on Jul 8, 2019, 15:19

assigned to @StephenThompson and unassigned @MattClarkson

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Dec 17, 2019, 15:54

merged

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Dec 17, 2019, 15:54

mentioned in commit 52de983eb48a0af4aa41ab0221c470414407affa