search

SciKit-Surgery / scikit-surgerybard

BARD: The Basic Augmented Reality Demo, used at MedICSS summer school.
https://scikit-surgerybard.readthedocs.io/
Other
7 stars 3 forks source link

Make pivot calib unit test actually test the result. #7

Closed thompson318 closed 4 years ago

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Apr 30, 2019, 16:11

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 1, 2019, 15:30

mentioned in commit 24f6246020393e87e296160e0d24af17f28100db

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 1, 2019, 15:31

marked the task Fix output directory name to be not hard coded as completed

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 1, 2019, 16:48

mentioned in commit a138ddc5aa427ae4a37fb9625f6333fa211494ac

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 2, 2019, 14:18

mentioned in commit 440a6809ed63700d1cb2d8c9e50b4326d20e77dc

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 2, 2019, 14:34

mentioned in commit 7270ae6ab354bdac7641d3b897ce3ae3a768ee9e

thompson318 commented 4 years ago

In GitLab by @MattClarkson on May 3, 2019, 10:55

i thought this was done?

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 3, 2019, 10:57

I am working on this one. Writing unit tests etc.

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 3, 2019, 15:02

mentioned in commit 8e0f5155383571ecba77cb218a253d4ce15dece2

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 3, 2019, 16:08

mentioned in commit 550eaec5b4e35ad763deedfb001f6cc2ab37d092

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 3, 2019, 16:19

mentioned in commit 92a70aee41ef419e8badd0977cb964be39df465d

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 4, 2019, 11:05

marked the task remove pivot calibration code duplication as completed

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 7, 2019, 14:39

marked the task add scikit-surgerycore as dependency in requirements.txt and rebuild .tox folder. as completed

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 7, 2019, 14:39

marked the task run_demo should return pivot point as completed

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 7, 2019, 14:39

marked the task unit test should assert the right value as completed

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 7, 2019, 14:39

created merge request !3 to address this issue

thompson318 commented 4 years ago

In GitLab by @MianAhmad on May 7, 2019, 14:39

mentioned in merge request !3

thompson318 commented 4 years ago

In GitLab by @MianAhmad on Jun 6, 2019, 19:16

mentioned in commit 5e140a0e806fcd6ca390d460237d3d6270a2eb5f

thompson318 commented 4 years ago

In GitLab by @MianAhmad on Jun 6, 2019, 19:23

mentioned in commit edff772a62dbf05efad3ec89253ba2bdd453dfa9

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Jun 11, 2019, 12:14

Can this be closed?

thompson318 commented 4 years ago

In GitLab by @MianAhmad on Jun 11, 2019, 12:54

You rejected one of the merge request. I need to check if it was that one. If yes, I will create another merge request. After merging the issue can be close.

thompson318 commented 4 years ago

In GitLab by @MianAhmad on Jun 11, 2019, 14:23

created merge request !4 to address this issue

thompson318 commented 4 years ago

In GitLab by @MianAhmad on Jun 11, 2019, 14:23

mentioned in merge request !4

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Jun 19, 2019, 17:20

closed