Add PointDetector and Aruco, ChArUco and Chessboard implementation #26

Closed thompson318 closed 4 years ago

In GitLab by @MattClarkson on Mar 20, 2019, 10:49

For example:

C++ interface here: https://cmiclab.cs.ucl.ac.uk/CMIC/NiftyCal/blob/master/Code/niftkIPoint2DDetector.h

C++ implementation here: https://cmiclab.cs.ucl.ac.uk/CMIC/NiftyCal/blob/master/Code/Detectors/niftkAprilTagsPointDetector.cxx

using April tags, not Aruco, so we need something similar in scikit-surgeryimage.

[ ] In sksurgeryimage/points/point_detector.py, add base class PointDetector
[ ] In sksurgeryimage/points/aruco_point_detector.py implement ArucoPointDetector
[ ] In tests/points/test_aruco_point_detector.py implement unit tests

Get test image from @StephenThompson maybe? Or just grab one off internet.

In GitLab by @MianAhmad on Mar 20, 2019, 10:54

@StephenThompson could we meet today at your convenience to discuss it please.

In GitLab by @StephenThompson on Mar 20, 2019, 11:42

Yes, we could meet around 2:00. There is some test images here ...

https://weisslab.cs.ucl.ac.uk/WEISS/SoftwareRepositories/SNAPPY/scikit-surgeryarucotracker/tree/1-get-working/data

In GitLab by @MianAhmad on Mar 20, 2019, 11:54

@StephenThompson cool. Thanks.

In GitLab by @MattClarkson on Apr 2, 2019, 12:38

@GuofangXiao - see this issue, it would be of interest for anyone detecting points in an image, eg. OpenCV chessboard corners, Charuco points, or just Aruco points.

In GitLab by @MattClarkson on Apr 3, 2019, 11:03

mentioned in commit 8231a2524fdb95f52aab47cf9630a665bb1b3e44

In GitLab by @MattClarkson on Apr 3, 2019, 11:03

mentioned in commit 5a538fe904605895c25989342ae3da00f021614b

In GitLab by @MattClarkson on Apr 3, 2019, 11:03

changed title from Add PointDetector and Aruco implementation to Add PointDetector and Aruco{+, ChArUco and Chessboard+} implementation

In GitLab by @MattClarkson on Apr 3, 2019, 11:03

@GuofangXiao - I just pushed branch 26-point-detector in scikit-surgeryimage.

In GitLab by @MattClarkson on Apr 3, 2019, 12:10

mentioned in commit fe69471052318192748108a371123153ef021785

In GitLab by @MattClarkson on Apr 3, 2019, 12:10

mentioned in commit 239f22b4e9965d6b9a8cff773456576af66477f7

In GitLab by @MattClarkson on Apr 3, 2019, 17:37

mentioned in commit 8bbbbd4055f0dce1ab52a0c54cc0454513ddf9ed

In GitLab by @MattClarkson on Apr 3, 2019, 17:37

mentioned in commit 42b321e410c545066ab8c69bb90e745b4791c05e

In GitLab by @MattClarkson on Apr 3, 2019, 18:02

mentioned in commit 071cf7735853c1674edb01d539455ba2a06b8bed

In GitLab by @MattClarkson on Apr 3, 2019, 21:16

Done, providing a standard interface for Chessboard, ChArUco and ArUco point detectors.

In GitLab by @MattClarkson on Apr 3, 2019, 21:16

closed

SciKit-Surgery / scikit-surgeryimage

Add PointDetector and Aruco, ChArUco and Chessboard implementation #26