SciKit-Surgery / scikit-surgerytutorial02

SciKit-Surgery Tutorial02 provides a tutorial on how to implement a simple algorithm using the SciKit-Surgery project's Python Template
http://scikit-surgerytutorial02.readthedocs.io/en/latest/?badge=latest
Other
1 stars 1 forks source link

Updating documentation from review #25 #26

Closed mxochicale closed 1 year ago

mxochicale commented 2 years ago

Miscellaneous

List of items to update in a new branches

"""scikit-surgery-sphere-fitting tests"""

from sksurgeryspherefitting.ui.sksurgeryspherefitting_demo import run_demo

def test_fit_sphere_least_squares_demo(): model_name = 'data/CT_Level_1.vtp' output_name = 'out_temp.vtp'

run_demo(model_name, output_name)
* [x] Command test that is useful for me: `pylint --rcfile=tests/pylintrc scikitsurgeryspherefitting`
* [x] `source .tox/py36/bin/activate` might be not necesary when using conda env covering all dependencies at https://scikit-surgerytutorial02.readthedocs.io/en/latest/07_UserInterface.html
* [x] Not sure how to run vtk viewer, just managed: 

wget https://github.com/thompson318/scikit-surgery-sphere-fitting/raw/master/data/US_Sphere_2.vtp

(scikit-surgery-VE) miguel@smartliveri4i-Alienware-13-R3:~/repositories/SciKit-Surgery/scikit-surgery-sphere-fitting$ python sksurgeryspherefitting.py data/CT_Level_1.vtp -o sphere.vtp Result is (array([136.571217 , 151.97335771, -95.51789211, 8.11853981]), 2) (scikit-surgery-VE) miguel@smartliveri4i-Alienware-13-R3:~/repositories/SciKit-Surgery/scikit-surgery-sphere-fitting$ python sksurgeryspherefitting.py data/US_Sphere_2.vtp -o sphere.vtp Result is (array([252.96783239, 216.57631804, 270.37878929, 596.29375964]), 2)


   Steve recommends to use: https://kitware.github.io/vtk-js/examples/GeometryViewer.html 

* [x] Incomplete install_requires in `. Open it and edit it. The most important thing to do is to update the “install_requires" ` https://scikit-surgerytutorial02.readthedocs.io/en/latest/09_Releaseing.html

_Originally posted by @mxochicale in https://github.com/SciKit-Surgery/scikit-surgerytutorial02/issues/25#issuecomment-1280888442_
mxochicale commented 2 years ago

name: scikit-surgery-VE channels:


* [x] Also, other dependencies like pandoc: Do I need `Pandoc wasn't found.` for tox -e docs
  * `scikit-surgery-VE; pip pandoc` don't work
  * in the terminal `sudo apt install pandoc`  > `docs: commands succeeded congratulations :)`
mxochicale commented 2 years ago

Meeting 1:1 w/Steve 19-Oct-2022 at 11:00

mxochicale commented 1 year ago

Screenshot from 2022-10-26 14-50-36 https://scikit-surgerytutorial02.readthedocs.io/en/latest/01_Starting_Out.html