search

SciLifeLab / NGI-RNAseq

Nextflow RNA-Seq Best Practice analysis pipeline, used at the SciLifeLab National Genomics Infrastructure.
https://ngisweden.scilifelab.se/
MIT License
51 stars 42 forks source link

Don't use uppmax.config for uppmax-modules.config #202

Closed ewels closed 6 years ago

ewels commented 6 years ago

Short term workaround until nextflow-io/nextflow#628 is released.

Should fix the problem where the uppmax-modules config tries to download the singularity container even when it's not needed.

ewels commented 6 years ago

Oops, accidentally added in another change on top of this PR sorry. Hopefully both fine though ✨

Hammarn commented 6 years ago

Ok,cool! Not the solution I was expecting. @ewels have you tried this on Rackham?

ewels commented 6 years ago

Yes was a bit of a quick fix for the modules config thing. Could do something nicer, especially when the nextflow bugfix is released. Shout if you have a better idea.

No test on rackham yet, no sorry.

ewels commented 6 years ago

Cool! Is it working properly now then?

Hammarn commented 6 years ago

Yes, I think so. I had an error with rseqc but that seemed unrelated. You didn't change any of that code. I'm trying again to see.