SciLifeLab / Sarek

Detect germline or somatic variants from normal or tumour/normal whole-genome or targeted sequencing
https://nf-co.re/sarek
MIT License
132 stars 6 forks source link

add sorted list of empty process resource specification to the #768

Closed KochTobi closed 4 years ago

KochTobi commented 5 years ago

Add list of processes to base config

Currently there are resource definitions for cpu, mem and time in some but not in all configuration profiles.

I think it would be nice to have a sorted list of processes in the base.config file where each process defines its preferred resources. The maximal ressurces from the environment specific configuration profiles can then be used to check for limitation.

The list should contain all processes. If I missed something feel free to add them.

Also there is no configuration for the single processes yet. It would be great if we could come up with some sort of preferred resource demands and add them together (over time?)

PR checklist

Learn more about contributing: https://github.com/SciLifeLab/Sarek/blob/master/.github/CONTRIBUTING.md

KochTobi commented 5 years ago

I can't figure out what's wrong with my config. ERROR ~ Unknown config attribute process.withName:BuildWithDocker -- check config file: /home/travis/build/SciLifeLab/Sarek/nextflow.config

maxulysse commented 5 years ago

I'll check it out right now

maxulysse commented 5 years ago

I actually have no idea, but if you remove all of the process from build.nf, it seems to be working...

KochTobi commented 5 years ago

I actually have no idea, but if you remove all of the process from build.nf, it seems to be working...

That' strange. Should I remove them then?

maxulysse commented 5 years ago

Yes, you definitively can, this build.nf script is not really part of the pipeline

maxulysse commented 4 years ago

Closing, this this is handled differently since the port to nf-core