SciLifeLab / TACA

Tool for the Automation of Cleanup and Analyses: tools for projects and data management at NGI Stockholm
MIT License
13 stars 16 forks source link

TACA demultiplexing need to use Undetermined reads #112

Open vezzi opened 9 years ago

vezzi commented 9 years ago

@guillermo-carrasco and @Galithil (I add @parlundin and @senthil10 for knowledge and suggestions) this issue is about the use of Undetermined reads in Xten after demultiplexing. You need to coordinate on which pat of the code work, but this is a part the needs to be plugged in after demultiplexing and before sending data to Nestor, so it should not difficult to work in separation and then merge your work.

Pseudo code after demultiplexing

the conditions (subject to changes are):

the last point can be applied also to lane.undetermine_prop_for_pooled_data, however I think that for now we have experience only with the second case, so we need to see some of these demultiplexed flowcells before take some decision.

senthil10 commented 9 years ago

hej @vezzi I have a question, whether all the projects run on a Hiseq-X will be process/analyzed/delivered from Nestor even though the project is not a IGN project ?

A suggestion for pseudo code (mostly what you said) :)

for lane in FC:
    lane_type = 'pooled' if lane.is_pooled else 'single'
    if lane.ok_to_proceed(type=lane_type):
        Bingo!! Proceed!!
    else:
        Stop and Mail user

def lane.ok_to_proceed(type):
     if undetermined > 10% and top_index > 40%:
        return False
     if type = single and Q30 < 75%:
        return False
    return True
Galithil commented 9 years ago

you definitely should add @remiolsen as he did work on that specific point for Hiseq runs.

vezzi commented 9 years ago

@senthil10 HiSeqX FC are transferred and processed only in Nestor, and delivered to Milou. IGN projects were a bit in the middle, they were moved to milou, and from milou to nestor to be processed.

guillermo-carrasco commented 9 years ago

@Galithil is this fixed with one of your latest PRs?

Galithil commented 9 years ago

it should be done, yes. onsite testing would be nice though.

On Tue, Jun 2, 2015 at 2:52 PM, Guillermo Carrasco <notifications@github.com

wrote:

@Galithil https://github.com/Galithil is this fixed with one of your latest PRs?

— Reply to this email directly or view it on GitHub https://github.com/SciLifeLab/TACA/issues/112#issuecomment-107943496.

guillermo-carrasco commented 9 years ago

:+1: cool, close this when you're sure that is working then please :)