search

SciLifeLab / bcbb

Useful bioinformatics code, primarily in Python and R
http://bcbio.wordpress.com
10 stars 11 forks source link

Single sample on lane #294

Closed remiolsen closed 10 years ago

remiolsen commented 10 years ago
guillermo-carrasco commented 10 years ago

Can you take a look at why Travis is failing before the merge?

senthil10 commented 10 years ago

Sure thing :+1:

On Thu, Mar 27, 2014 at 4:18 PM, Guillermo Carrasco < notifications@github.com> wrote:

Can you take a look at why Travis is failing before the merge?

Reply to this email directly or view it on GitHubhttps://github.com/SciLifeLab/bcbb/pull/294#issuecomment-38816996 .

senthil10 commented 10 years ago

@guillermo-carrasco and @mariogiov : Travis is giving the following error

error: Installed distribution paramiko 1.13.0 conflicts with requirement paramiko>=1.10,<1.13

I guess it is not related to this pull request. It is in regard with some package issues ?! :O So should I wait until it is fixed (I believe either of you bigshots will take care of it) or can I go ahead and merge it anyway ?

remiolsen commented 10 years ago

@senthil10 I removed the paramiko dependency from bcbb dependencies. Paramiko is not referenced in the bcbb code, however it is a dependency of fabric.

I think it just became a circle of dependency hell.

guillermo-carrasco commented 10 years ago

We're in contact with Brad because it looks like the test data has changed, which could explain the error in Travi-CI. However, as this PR does not use the tests that are failing, I'll go on and merge it.

senthil10 commented 10 years ago

@guillermo-carrasco : Thanks a bunch :+1: