Contamination rates for fastq_screen corrected

SciLifeLab / facs

Fast and Accurate Classification of Sequences using Bloom filters

http://facs.scilifelab.se/

Other

16 stars 9 forks source link

Contamination rates for fastq_screen corrected #102

Closed brainstorm closed 10 years ago

brainstorm commented 10 years ago

Now FACS and fastq_screen report similar contamination rates, it was a silly error in test_fastqscreen.py:

http://nbviewer.ipython.org/github/brainstorm/facs/blob/a669816c/facs/utils/benchmarks_facs.ipynb?create=1

Also, the default threads in FACS seem to be always 1, regardless of export OMP_NUM_THREADS environment variable. @tzcoolman, can you check and test this out?

I'll be generating plots for the recall and precision soon.

Solves issue #99.

guillermo-carrasco commented 10 years ago

Looks great! Good job :-)