search

SciLifeLab / facs

Fast and Accurate Classification of Sequences using Bloom filters
http://facs.scilifelab.se/
Other
16 stars 9 forks source link

We are not supporting fasta format anymore? #42

Closed tzcoolman closed 11 years ago

tzcoolman commented 11 years ago

@brainstorm @arvestad @henrikstranneheim I saw u have merged your changes to scilifelab/facs. And you deleted the fasta_read_check and fasta_full_check. Changing names for some variable is fine. But u sure we dont need both functions any more?

brainstorm commented 11 years ago

Enze, as far as I know, I did not merge those branches into scilifelab/facs master branch yet, they are in brainstorm/facs "inline_python_query" and "build_revamp" branches for now.

Both fasta/fastq formats are supported transparently by Heng Li's readfq module, without the need of specific functions (nor replicated code) for fasta format. Den 9 apr 2013 02:04 skrev "Enze Liu" notifications@github.com:

@brainstorm https://github.com/brainstorm @arvestad https://github.com/arvestad @henrikstranneheim https://github.com/henrikstranneheim I saw u have merged your changes to scilifelab/facs. And you deleted the fasta_read_check and fasta_full_check. Changing names for some variable is fine. But u sure we dont need both functions any more?

— Reply to this email directly or view it on GitHubhttps://github.com/SciLifeLab/facs/issues/42 .