search

SciML / ADTypes.jl

Repository for automatic differentiation backend types
https://sciml.github.io/ADTypes.jl/
MIT License
36 stars 11 forks source link

Give `AutoSparseFiniteDiff` the same type parameters as `AutoFiniteDiff` #33

Closed gdalle closed 3 months ago

gdalle commented 3 months ago

Is there a reason why AutoFiniteDiff specifies the finite difference mode and AutoSparseFiniteDiff doesn't?

ChrisRackauckas commented 3 months ago

Just oversight.

gdalle commented 3 months ago

would this be considered a breaking change to add them, given that everything is documented now?

ChrisRackauckas commented 3 months ago

No, adding arguments with defaults wouldn't be breaking.

gdalle commented 3 months ago

But adding a type parameter might be? https://discourse.julialang.org/t/is-adding-a-type-parameter-to-a-struct-a-breaking-change/111236

ChrisRackauckas commented 3 months ago

it is not. There is no code that would dispatch differently if you added a type parameter there.

gdalle commented 3 months ago

fair enough. I'll open a PR