Support Julia 1.6 (again)

SciML / ADTypes.jl

Repository for automatic differentiation backend types

https://sciml.github.io/ADTypes.jl/

MIT License

36 stars 11 forks source link

Support Julia 1.6 (again) #48

Closed gdalle closed 2 months ago

gdalle commented 3 months ago

Checklist

[x] Appropriate tests were added
[x] Any code changes were done in a way that does not break public API
[x] All documentation related to code changes were updated
[x] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[x] Any new documentation only uses public API

Additional context

This PR makes EnzymeCoreExt and ChainRulesExt unconditional dependencies for Julia <1.9, thus allowing support for older Julia versions. We initially decided against it in https://github.com/SciML/ADTypes.jl/pull/40#issuecomment-2055319884, but as shown by #47 some users would like this feature. It is zero-cost for us, so why not?

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (aa2429e) to head (fa3733a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #48 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 6 6 Lines 64 64 ========================================= Hits 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 3 months ago

@ChrisRackauckas @Vaibhavdixit02 I think this doesn't hurt, right?

gdalle commented 2 months ago

Bump @Vaibhavdixit02

ChrisRackauckas commented 2 months ago

If you all want to maintain it, go for it. We don't plan to put any effort into the old LTS since the new one is already out.

gdalle commented 2 months ago

I didnt have that in mind, so all of SciML is basically willing to drop 1.6?

ChrisRackauckas commented 2 months ago

Yes.