SciML / ADTypes.jl

Repository for automatic differentiation backend types
https://sciml.github.io/ADTypes.jl/
MIT License
36 stars 11 forks source link

ci: standardise workflows using SciML's reusable workflows #50

Closed thazhemadam closed 2 months ago

thazhemadam commented 2 months ago

Update the workflows in this repository to use SciML's reusable workflows. This is part of a larger effort to standardise the SciML's CI workflows for more generic and common requirements, to keep the workflows uniform and easier to maintain.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (43f1a41) to head (a67c600).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 6 6 Lines 64 64 ========================================= Hits 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 2 months ago

Where does this build the docs? And are they updated directly upon each merged PR?

thazhemadam commented 2 months ago

The documentation is still built on the same events as it is at present, i.e., on pushes to main, on all tags pushed and on all pull requests opened. The status quo is expected to remain unchanged. https://github.com/SciML/ADTypes.jl/blob/0f86da069c526ad1b785aca415026e1610c534ff/.github/workflows/Documentation.yml#L3-L8

gdalle commented 2 months ago

I mean on which website, does it go to a centralized SciML docs or does it stay here?

thazhemadam commented 2 months ago

Ah, I see. Sorry about the misunderstanding. The documentation deployments will continue to stay here, as specified in the deploydocs method. https://github.com/SciML/ADTypes.jl/blob/a67c600dacccdf1c55b9e975bdc0b4621fec2dd4/docs/make.jl#L11

gdalle commented 2 months ago

Sounds good to me, but I'll let someone from the org like @Vaibhavdixit02 review and merge, I only have rights to this specific repo

Vaibhavdixit02 commented 2 months ago

Even though it passed tests in the PR the CI on master seems to have broken can you take a look @thazhemadam?

gdalle commented 2 months ago

I re-ran the failed workflows and it worked, I think it was just a Codecov glitch