Broken constructor in v1.5

SciML / ADTypes.jl

Repository for automatic differentiation backend types

https://sciml.github.io/ADTypes.jl/

MIT License

36 stars 11 forks source link

Broken constructor in v1.5 #65

Closed mhauru closed 3 weeks ago

mhauru commented 3 weeks ago

ADTypes.AutoReverseDiff(false) used to be a valid way to call the constructor before v1.5 and https://github.com/SciML/ADTypes.jl/commit/efdc12e72b44dba4f858bbef85c2835b2347f50e, but now only the keyword argument version works. I appreciate that the positional argument constructor was undocumented, but maybe a deprecation warning could still be put in place?

ChrisRackauckas commented 3 weeks ago

Yeah we can add that as a deprecation path. Totally not intended as a constructor to use before 😅, but no harm in making it a deprecation.