search

SciML / Catalyst.jl

Chemical reaction network and systems biology interface for scientific machine learning (SciML). High performance, GPU-parallelized, and O(1) solvers in open source software.
https://docs.sciml.ai/Catalyst/stable/
Other
463 stars 78 forks source link

test master #1048

Closed isaacsas closed 2 months ago

isaacsas commented 2 months ago

@ChrisRackauckas we're now getting test failures in ODE solvers at https://github.com/SciML/Catalyst.jl/blob/af5b8c249be995b1be6ae9e5140694c1fd853349/test/dsl/dsl_options.jl#L791

Nothing should have changed in Catalyst in the last day to cause this suddenly (tests passed yesterday). Is this related to initialization changes or structural_simplify changes?

cc: @TorkelE this looks like a DAE example you made?

isaacsas commented 2 months ago

Ahh, I see the issue.

@TorkelE this isn't a consistent initialization. At t = 0 the equations should hold, and as such X and Y are fully deteremined by S(0), however, you are specifying values for them. Can you update any such examples in the tests? There seem to be multiple failures now due to such issues.

ChrisRackauckas commented 2 months ago

Yes, that would be from https://github.com/SciML/ModelingToolkit.jl/pull/3032. It fixes @TorkelE 's issue of https://github.com/SciML/ModelingToolkit.jl/issues/2619 which there were cases we let inconsistent initial conditions through before. Now that we plugged that, yes that would error now 😅

TorkelE commented 2 months ago

Glad to see that it got fixed. Yes, superfluous initial conditions should be removed now, I should be able to get to it in a day or so

isaacsas commented 2 months ago

Thanks!