SciML / Catalyst.jl

Chemical reaction network and systems biology interface for scientific machine learning (SciML). High performance, GPU-parallelized, and O(1) solvers in open source software.
https://docs.sciml.ai/Catalyst/stable/
Other
460 stars 77 forks source link

drop scalarizing #1052

Closed isaacsas closed 1 week ago

isaacsas commented 2 weeks ago

Closes https://github.com/SciML/Catalyst.jl/issues/1051

Not handled yet

WIth this PR the DSL will still scalarize non-parameters, but I believe this is consistent with MTK now.

isaacsas commented 1 week ago

@TorkelE if tests pass I am happy with this (I'd like to get a new release with this out). Can you let me know if it looks OK to you?

I guess the only other question is if this requires a breaking release? I think it may since we are changing how parameters are handled to drop scalarizing, which will break peoples existing codes unfortunately. If you are OK I'll make this V15 and add a note that removing scalarizing is the only change.