search

SciML / Catalyst.jl

Chemical reaction network and systems biology interface for scientific machine learning (SciML). High performance, GPU-parallelized, and O(1) solvers in open source software.
https://docs.sciml.ai/Catalyst/stable/
Other
465 stars 78 forks source link

scalarization in spatial code #1059

Open isaacsas opened 2 months ago

isaacsas commented 2 months ago

Since tests are now passing and I am not that familiar with the code, I haven't updated any spatial related codes to remove scalarization of parameters in https://github.com/SciML/Catalyst.jl/pull/1052. This should probably be fixed up at some point though for consistency.

TorkelE commented 2 months ago

I'll have to have a think at whether this actually matters to the spatial code at all, since it just considers models after they are created. Either case I should add some tests to ensure that this is the case.