SciML / Catalyst.jl

Chemical reaction network and systems biology interface for scientific machine learning (SciML). High performance, GPU-parallelized, and O(1) solvers in open source software.
https://docs.sciml.ai/Catalyst/stable/
Other
460 stars 77 forks source link

fix: turn off parameter splitting for `BifurcationProblem` #1071

Open AayushSabharwal opened 21 hours ago

AayushSabharwal commented 21 hours ago

BifurcationProblem does not support symbolic indexing and as a result, MTK (somewhat hackily) just removes sys.index_cache in the BifurcationProblem constructor to force split = false behavior. However, with complete now reordering parameters, this breaks assumptions and makes analysis of these problems difficult.

In hindsight, BifurcationProblem should have just errored if the system was created with split=true, but changing that behavior is breaking. I will add a warning in MTK. For now, this should fix CI

Checklist

Additional context

Add any other context about the problem here.