search

SciML / Catalyst.jl

Chemical reaction network and systems biology interface for scientific machine learning (SciML). High performance, GPU-parallelized, and O(1) solvers in open source software.
https://docs.sciml.ai/Catalyst/stable/
Other
460 stars 77 forks source link

fix Catalyst using warning #944

Closed isaacsas closed 3 months ago

isaacsas commented 3 months ago

Hopefully fixes the warning when calling using Catalyst.

TorkelE commented 3 months ago

Thanks!

There are also these two which have been around for a while

WARNING: both Symbolics and ModelingToolkit export "infimum"; uses of it in module Catalyst must be qualified
WARNING: both Symbolics and ModelingToolkit export "supremum"; uses of it in module Catalyst must be qualified

which I really do not know how to fix. Chris suggested that it might have something with DomainSet to do, but I also see it when loading Catalyst normally sometimes, so not sure.

isaacsas commented 3 months ago

Those aren't Catalyst related, and I don't see them currently. (There are other ones I am seeing from other packages, but we can't handle those.)

isaacsas commented 3 months ago

Looking at the test warnings the only one I don't know how to fix, or even what is causing it is

┌ Warning: dot() is deprecated, use the non-do-block form

I assume it is GraphViz_jll.related, but I can't find where this warning is even created.

The remaining warnings are all I believe from packages we depend on. Primarily SteadyStateDiffEq.

TorkelE commented 3 months ago

I wen through the warnings in the previous PR and couldn't really figure them out either. I did some testing especially on the SteadyState ones, but couldn't reproduce them when I ran them just in a normal script, so not sure exactly what to do.

isaacsas commented 3 months ago

Did you turn warnings on via the command line flag when you ran your normal script?

TorkelE commented 3 months ago

I just ran it in a VSCode window. That usually produces warnings from some stuff, but there might definitely be some details I am unaware of to how warnings are generated which affected this.

isaacsas commented 3 months ago

I think that one needs to start Julia with julia --depwarn=yes to see such warnings when running code outside of the testing mode.

TorkelE commented 3 months ago

yeah, that sounds like something I might have missed, will probably circle back to this at some later point in time equipped with this knowledge.