SciML / Catalyst.jl

Chemical reaction network and systems biology interface for scientific machine learning (SciML). High performance, GPU-parallelized, and O(1) solvers in open source software.
https://docs.sciml.ai/Catalyst/stable/
Other
437 stars 71 forks source link

unit problems in tests #945

Closed isaacsas closed 3 weeks ago

isaacsas commented 3 weeks ago

┌ Warning: Species are expected to have units of 1.0 m⁻³ mol however, species B(t) has units 1.0 mol. └ @ Catalyst ~/work/Catalyst.jl/Catalyst.jl/src/reactionsystem.jl:1453 ┌ Warning: Reaction rate laws are expected to have units of 1.0 m⁻³ s⁻¹ mol however, k2, ∅ --> A has units of 1.0 kg. └ @ Catalyst ~/work/Catalyst.jl/Catalyst.jl/src/reactionsystem.jl:1481 ┌ Warning: Reaction rate laws are expected to have units of 1.0 m⁻³ s⁻¹ mol however, k2, A --> B has units of 1.0 m⁻³ kg mol. └ @ Catalyst ~/work/Catalyst.jl/Catalyst.jl/src/reactionsystem.jl:1481 ┌ Warning: Reaction rate laws are expected to have units of 1.0 m⁻³ s⁻¹ mol however, k3, A + B --> 2*B has units of 1.0 s⁻¹ mol. └ @ Catalyst ~/work/Catalyst.jl/Catalyst.jl/src/reactionsystem.jl:1481

isaacsas commented 3 weeks ago

Don't know if this is a test issue or general unit code issue, but it should get fixed in either case.