SciML / Catalyst.jl

Chemical reaction network and systems biology interface for scientific machine learning (SciML). High performance, GPU-parallelized, and O(1) solvers in open source software.
https://docs.sciml.ai/Catalyst/stable/
Other
437 stars 71 forks source link

update unicode "₊" separator to "." #949

Open isaacsas opened 3 weeks ago

isaacsas commented 3 weeks ago

https://github.com/SciML/ModelingToolkit.jl/pull/2798

We need to propagate this throughout Catalyst where needed (probably some tutorials, tests, and the symmap_to_varmap code). Also need to update to depend on MTK 9.18 or later only.

ChrisRackauckas commented 2 weeks ago

https://github.com/SciML/Catalyst.jl/pull/951

isaacsas commented 2 days ago

There are still some tests and docs that explicitly use "₊". We need to update them whenever MTK decides to change the separator.

ChrisRackauckas commented 2 days ago

Just use the general separator const?

isaacsas commented 2 days ago

Yup that is all that needs to be done for the tests, but the doc example will require a bit more tweaking.