search

SciML / Catalyst.jl

Chemical reaction network and systems biology interface for scientific machine learning (SciML). High performance, GPU-parallelized, and O(1) solvers in open source software.
https://docs.sciml.ai/Catalyst/stable/
Other
437 stars 71 forks source link

Tests for conservation laws and `remake` #953

Closed TorkelE closed 2 weeks ago

TorkelE commented 2 weeks ago

Some stuff is broken, although maybe not exactly the stuff that we thought was.

ChrisRackauckas commented 2 weeks ago

Can you share the MTK system created from this so I can talk about it without grabbing the Catalyst in progress branch? Most of those don't look "broken", it looks like you specified an incompatible system.

TorkelE commented 2 weeks ago

Will do. I think right now I am not 100% certain that the errors are fully in MTK (i.e. some of the failed conservation law issues look odd). Once we know what might actually be an MTK problem I will make corresponding issues over there (using MTK systems) instead.

TorkelE commented 2 weeks ago

Maybe we reopen this in the future, but for now we will probably use https://github.com/SciML/Catalyst.jl/pull/955 instead.