search

SciML / CellMLToolkit.jl

CellMLToolkit.jl is a Julia library that connects CellML models to the Scientific Julia ecosystem.
https://docs.sciml.ai/CellMLToolkit/stable/
Other
62 stars 15 forks source link

Update to MTK 9 #128

Closed termi-official closed 1 month ago

termi-official commented 1 month ago

Updates to new MTK version and hot-fixes master CI.

termi-official commented 1 month ago

I cannot reproduce the downgrade issue locally with https://github.com/julia-actions/julia-downgrade-compat/blob/main/downgrade.jl .

ChrisRackauckas commented 1 month ago

I wouldn't worry too much about downgrade.

Is the only failure now Aqua?

termi-official commented 1 month ago

Yes. Aqua only fails in CI. It does not fail locally. I will try to dig into this later.

termi-official commented 1 month ago

The last commit should fix the compat issue. However, I could not find any way to reproduce the CI failure locally.

Edit: Can now (thanks to Fredrik Ekre)

termi-official commented 1 month ago

Okay the Aqua failure is essentially https://github.com/SciML/ModelingToolkit.jl/issues/2827. I think I can fix this.

termi-official commented 1 month ago

CI fails now locally with a different error using the SymbolicUtils.jl fix. But the Aqua issue seems to be resolved at least.

termi-official commented 1 month ago

I think I fixed all issues now.