Closed Gregliest closed 3 years ago
Hey Greg!
Very nice work so far! Thank you!
I added some minor discussion points / proposals for changes and reminder for myself :sweat_smile: .
For your list above:
I am fully back and just adjusting to be fully back right now, so feel free to DM on Slack or keep this conversation going.
Ah, and I compiled an initial list of references here.
Once you feel that this PR is mature enough, I can jump in and add it and DocumenterCitations.jl .
Ok, I think this PR is in a decent place. I'd still like to check it using your LiveServer.jl workflow, so I can make sure the png's and optional module elements are working properly. But, I think most things are in and working, and stuff is reasonably proofread at this point.
This PR reorganizes the docs as suggested in #247. I've taken a lot of liberties in reorganizing, with the rough outline as follows:
To me, this outline made the most sense because the general workflow is:
However, let me know if you'd like something different.
This PR still has some outstanding issues and questions:
monomial_basis
to return a basis, not a vector of equations. I'll call that out in the docs, but it might be clearer to name them something likemonomial_basis_eqs
or something like that. [Addressed below]