search

SciML / DataDrivenDiffEq.jl

Data driven modeling and automated discovery of dynamical systems for the SciML Scientific Machine Learning organization
https://docs.sciml.ai/DataDrivenDiffEq/stable/
MIT License
405 stars 57 forks source link

is function for forward and backward DMD welcome as PR? #313

Closed yewalenikhil65 closed 2 years ago

yewalenikhil65 commented 2 years ago

I have implemented the forward and backward DMD function (fbDMD). Is it okay to contribute as PR ? It is fbDMD without control. This version of DMD is said to be good for overcoming the noise effects in the literature I have implemented it as directed in the appendix of the paper Integrating multi-fidelity blood flow data with reduced-order data assimilation The implementation can be found here in the fork of DataDrivenDiffEq.jl at here I do not yet know how the tests in DataDrivenDiffEq.jl work so might need some help with the tests!

AlCap23 commented 2 years ago

Awesome, that would be most welcome! Feel free to start a PR and we can then discuss the tests in the process.

I'll also have a look on how to integrate the control signal.

yewalenikhil65 commented 2 years ago

Awesome, that would be most welcome! Feel free to start a PR and we can then discuss the tests in the process.

I'll also have a look on how to integrate the control signal.

thanks, for now i have opened a PR-314

yewalenikhil65 commented 2 years ago

https://github.com/SciML/DataDrivenDiffEq.jl/pull/337 seems this should be closed now