search

SciML / DataDrivenDiffEq.jl

Data driven modeling and automated discovery of dynamical systems for the SciML Scientific Machine Learning organization
https://docs.sciml.ai/DataDrivenDiffEq/stable/
MIT License
404 stars 57 forks source link

Update SymbolicRegression.jl #346

Closed MilesCranmer closed 2 years ago

MilesCranmer commented 2 years ago

See https://github.com/MilesCranmer/SymbolicRegression.jl/pull/84 - should finally be cross-compatible with latest SymbolicUtils.jl

AlCap23 commented 2 years ago

I will have a look later this evening. Probably the deps in DataDriven.

ChrisRackauckas commented 2 years ago

You probably need to do https://github.com/MilesCranmer/DataDrivenDiffEq.jl/pull/1

ChrisRackauckas commented 2 years ago

FYI, I think we should completely eliminate requires and make it a subpackage like how GalacticOptim.jl does it https://github.com/SciML/GalacticOptim.jl

AlCap23 commented 2 years ago

I'll have to work on fixing some of the issues w.r.t. Symbolics 0.19, which is currently failing. Will do that in a different PR and merge it in.

I've taken a quick look at the substructure in GalacticOptim and have to wrap my head around this a little more, but we can take a look at it.

AlCap23 commented 2 years ago

I'll close this one in favour of #349 where I had to change some additional material and give credit to both of you in the squash if its alright.