SciML / DataDrivenDiffEq.jl

Data driven modeling and automated discovery of dynamical systems for the SciML Scientific Machine Learning organization
https://docs.sciml.ai/DataDrivenDiffEq/stable/
MIT License
402 stars 56 forks source link

Major Refactoring into API and Subpackages #371

Closed AlCap23 closed 1 year ago

AlCap23 commented 1 year ago

Supersedes #355 and probably #363 .

Add subpackages for

~~ OccamNet - This will be an individual PR given that I adapt for Lux.jl~~

AlCap23 commented 1 year ago

The base functionality should be relatively stable now ( give or take ).

The main API solve(problem, [basis], alg; options) is relatively untouched. I need to convert possible kwargs to DataDrivenCommonOptions, but this is it.

These are hard, but necessary changes and probably a step in the right direction ( hence v1.0 from here on )

Note All invalidations come from Deps here. I might descent into madness to investigate this further

AlCap23 commented 1 year ago

Strange note:

When running the pendulum tests locally, I get the expected result from Pkg.test() iff I include the info print. If not, the test fail. This seems super strange. If I include it, everything works out. Maybe I should wrap everything inside a safetestset. Lets see what the CI holds here.

Edit: I relaxed it a little. Might be the RNG.

Additionally, Implicit now works reliable and rejects results without implicit variable dependencies. This discards results like 1 = sin^2 + cos^2.

AlCap23 commented 1 year ago

LGTM. Will merge in approx. 8 hrs.