search

SciML / DataInterpolations.jl

A library of data interpolation and smoothing functions
MIT License
203 stars 43 forks source link

Error displaying symbolic interpolations #244

Closed chooron closed 2 months ago

chooron commented 2 months ago

When ModelingToolkit.jl is updated from v9.9.0 to v9.12.0, there seems to be a bug in DataInterpolations.jl, as shown below:

using ModelingToolkit
using OrdinaryDiffEq
using DataInterpolations
using ModelingToolkit: t_nounits as t, D_nounits as D

@parameters α β γ δ
@variables x(t) y(t)

itp_func(t) = LinearInterpolation(rand(100), 1:100, extrapolate=true)(t)
eqs = [
    D(x) ~ (α - β * y) * x + itp_func(t)
    D(y) ~ (δ * x - γ) * y + itp_func(t)
]
@mtkbuild odesys = ODESystem(eqs, t)

When calling equations to view odesys (equations(odesys)), an error occurred. Error & Stacktrace ⚠️

2-element Vector{Equation}:
Error showing value of type Vector{Equation}:
ERROR: MethodError: no method matching nameof(::Vector{Real})

Closest candidates are:
  nameof(::Core.IntrinsicFunction)
   @ Base reflection.jl:1762
  nameof(::Num)
   @ Symbolics D:\Julia\Julia-1.10.0\packages\packages\Symbolics\HIg7O\src\num.jl:88
  nameof(::ModelingToolkit.LazyNamespace)
   @ ModelingToolkit D:\Julia\Julia-1.10.0\packages\packages\ModelingToolkit\pmsNn\src\systems\connectors.jl:147
  ...

Stacktrace:
  [1] show_call(io::IOContext{IOBuffer}, f::Vector{Real}, args::Vector{Any})
    @ SymbolicUtils D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\types.jl:771
  [2] show_term(io::IOContext{IOBuffer}, t::SymbolicUtils.BasicSymbolic{Real})
    @ SymbolicUtils D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\types.jl:816
  [3] show(io::IOContext{VSCodeServer.LimitIO{IOBuffer}}, v::SymbolicUtils.BasicSymbolic{Real})
    @ SymbolicUtils D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\types.jl:829 [inlined]
  [4] print(io::IOContext{IOBuffer}, x::SymbolicUtils.BasicSymbolic{Real})
    @ Base .\strings\io.jl:35
  [5] #print_arg#28
    @ D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\types.jl:674 [inlined]
  [6] print_arg
    @ D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\types.jl:670 [inlined]
  [7] print_arg(io::IOContext{IOBuffer}, f::Function, x::SymbolicUtils.BasicSymbolic{Real})
    @ SymbolicUtils D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\types.jl:679
  [8] show_add(io::IOContext{IOBuffer}, args::Vector{Any})
    @ SymbolicUtils D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\types.jl:707
  [9] show_term(io::IOContext{IOBuffer}, t::SymbolicUtils.BasicSymbolic{Real})
    @ SymbolicUtils D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\types.jl:806
 [10] show(io::IOContext{VSCodeServer.LimitIO{IOBuffer}}, v::SymbolicUtils.BasicSymbolic{Real})
    @ SymbolicUtils D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\types.jl:829 [inlined]
 [11] print(io::IOContext{IOBuffer}, x::SymbolicUtils.BasicSymbolic{Real})
    @ Base .\strings\io.jl:35
 [12] print(::IOContext{IOBuffer}, ::SymbolicUtils.BasicSymbolic{Real}, ::String, ::Vararg{Any})
    @ Base .\strings\io.jl:46
 [13] show(io::IOContext{IOBuffer}, eq::Equation)
    @ Symbolics D:\Julia\Julia-1.10.0\packages\packages\Symbolics\HIg7O\src\equations.jl:126
 [14] sprint(f::Function, args::Equation; context::IOContext{Base.TTY}, sizehint::Int64)
    @ Base .\strings\io.jl:112
 [15] sprint
    @ .\strings\io.jl:107 [inlined]
 [16] alignment_from_show
    @ Base .\show.jl:3003 [inlined]
 [17] alignment(io::IOContext{Base.TTY}, x::Equation)
    @ Base .\show.jl:3022
 [18] alignment(io::IOContext{Base.TTY}, X::AbstractVecOrMat, rows::Vector{Int64}, cols::Vector{Int64}, cols_if_complete::Int64, cols_otherwise::Int64, sep::Int64, ncols::Int64)        
    @ Base .\arrayshow.jl:69
 [19] _print_matrix(io::IOContext{…}, X::AbstractVecOrMat, pre::String, sep::String, post::String, hdots::String, vdots::String, ddots::String, hmod::Int64, vmod::Int64, rowsA::UnitRange{…}, colsA::UnitRange{…})
    @ Base .\arrayshow.jl:207
 [20] print_matrix(io::IOContext{Base.TTY}, X::Vector{Equation}, pre::String, sep::String, post::String, hdots::String, vdots::String, ddots::String, hmod::Int64, vmod::Int64)
    @ Base .\arrayshow.jl:171
 [21]
    @ Base .\arrayshow.jl:171 [inlined]
 [22] print_array
    @ .\arrayshow.jl:358 [inlined]
 [23] show(io::IOContext{Base.TTY}, ::MIME{Symbol("text/plain")}, X::Vector{Equation})
    @ Base .\arrayshow.jl:399
 [24] (::REPL.var"#55#56"{REPL.REPLDisplay{REPL.LineEditREPL}, MIME{Symbol("text/plain")}, Base.RefValue{Any}})(io::Any)
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:273
 [25] with_repl_linfo(f::Any, repl::REPL.LineEditREPL)
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:569
 [26] display(d::REPL.REPLDisplay, mime::MIME{Symbol("text/plain")}, x::Any)
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:259
 [27] display(d::REPL.REPLDisplay, x::Any)
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:278
 [28] display(x::Any)
    @ Base.Multimedia .\multimedia.jl:340
 [29] #invokelatest#2
    @ .\essentials.jl:887 [inlined]
 [30] invokelatest
    @ .\essentials.jl:884 [inlined]
 [31] print_response(errio::IO, response::Any, show_value::Bool, have_color::Bool, specialdisplay::Union{Nothing, AbstractDisplay})
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:315
 [32] (::REPL.var"#57#58"{REPL.LineEditREPL, Pair{Any, Bool}, Bool, Bool})(io::Any)
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:284
 [33] with_repl_linfo(f::Any, repl::REPL.LineEditREPL)
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:569
 [34] print_response(repl::REPL.AbstractREPL, response::Any, show_value::Bool, have_color::Bool)
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:282
 [35] (::REPL.var"#do_respond#80"{Bool, Bool, REPL.var"#93#103"{…}, REPL.LineEditREPL, REPL.LineEdit.Prompt})(s::REPL.LineEdit.MIState, buf::Any, ok::Bool)
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:911
 [36] (::VSCodeServer.var"#103#106"{REPL.var"#do_respond#80"{Bool, Bool, REPL.var"#93#103"{…}, REPL.LineEditREPL, REPL.LineEdit.Prompt}})(mi::REPL.LineEdit.MIState, buf::IOBuffer, ok::Bool)
    @ VSCodeServer c:\Users\OMEN\.vscode\extensions\julialang.language-julia-1.76.2\scripts\packages\VSCodeServer\src\repl.jl:122
 [37] #invokelatest#2
    @ Base .\essentials.jl:887 [inlined]
 [38] invokelatest
    @ Base .\essentials.jl:884 [inlined]
 [39] run_interface(terminal::REPL.Terminals.TextTerminal, m::REPL.LineEdit.ModalInterface, s::REPL.LineEdit.MIState)
    @ REPL.LineEdit D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\LineEdit.jl:2656
 [40] run_frontend(repl::REPL.LineEditREPL, backend::REPL.REPLBackendRef)
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:1312
 [41] (::REPL.var"#62#68"{REPL.LineEditREPL, REPL.REPLBackendRef})()
    @ REPL D:\Julia\Julia-1.10.0\share\julia\stdlib\v1.10\REPL\src\REPL.jl:386
Some type information was truncated. Use `show(err)` to see complete types.

Not only that, when I want to solve this problem,

odeprob = ODEProblem(odesys, [x => 1.0, y => 1.0], (0.0, 10.0), [α => 1.5, β => 1.0, γ => 3.0, δ => 1.0])
timesteps = 0.0:0.1:10.0
sol = solve(odeprob, Tsit5(); saveat=timesteps)

there is also an error:

ERROR: MethodError: objects of type Vector{Real} are not callable
Use square brackets [] for indexing an Array.
Stacktrace:
  [1] macro expansion
    @ D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\code.jl:418 [inlined]
  [2] macro expansion
    @ D:\Julia\Julia-1.10.0\packages\packages\Symbolics\HIg7O\src\build_function.jl:546 [inlined]
  [3] macro expansion
    @ D:\Julia\Julia-1.10.0\packages\packages\SymbolicUtils\c0xQb\src\code.jl:375 [inlined]
  [4] macro expansion
    @ D:\Julia\Julia-1.10.0\packages\packages\RuntimeGeneratedFunctions\Yo8zx\src\RuntimeGeneratedFunctions.jl:163 [inlined]
  [5] macro expansion
    @ .\none:0 [inlined]
  [6] generated_callfunc
    @ .\none:0 [inlined]
  [7] (::RuntimeGeneratedFunctions.RuntimeGeneratedFunction{…})(::Vector{…}, ::Vector{…}, ::Vector{…}, ::Float64)
    @ RuntimeGeneratedFunctions D:\Julia\Julia-1.10.0\packages\packages\RuntimeGeneratedFunctions\Yo8zx\src\RuntimeGeneratedFunctions.jl:150
  [8] (::ModelingToolkit.var"#f#708"{…})(du::Vector{…}, u::Vector{…}, p::ModelingToolkit.MTKParameters{…}, t::Float64)
    @ ModelingToolkit D:\Julia\Julia-1.10.0\packages\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:343
  [9] (::SciMLBase.Void{ModelingToolkit.var"#f#708"{…}})(::Vector{Float64}, ::Vararg{Any})
    @ SciMLBase D:\Julia\Julia-1.10.0\packages\packages\SciMLBase\NjslX\src\utils.jl:482
 [10] (::FunctionWrappers.CallWrapper{…})(f::SciMLBase.Void{…}, arg1::Vector{…}, arg2::Vector{…}, arg3::ModelingToolkit.MTKParameters{…}, arg4::Float64)
    @ FunctionWrappers D:\Julia\Julia-1.10.0\packages\packages\FunctionWrappers\Q5cBx\src\FunctionWrappers.jl:65
 [11] macro expansion
    @ D:\Julia\Julia-1.10.0\packages\packages\FunctionWrappers\Q5cBx\src\FunctionWrappers.jl:137 [inlined]
 [12] do_ccall
    @ D:\Julia\Julia-1.10.0\packages\packages\FunctionWrappers\Q5cBx\src\FunctionWrappers.jl:125 [inlined]
 [13] FunctionWrapper
    @ D:\Julia\Julia-1.10.0\packages\packages\FunctionWrappers\Q5cBx\src\FunctionWrappers.jl:144 [inlined]
 [14] _call
    @ D:\Julia\Julia-1.10.0\packages\packages\FunctionWrappersWrappers\9XR0m\src\FunctionWrappersWrappers.jl:12 [inlined]
 [15] FunctionWrappersWrapper
    @ D:\Julia\Julia-1.10.0\packages\packages\FunctionWrappersWrappers\9XR0m\src\FunctionWrappersWrappers.jl:10 [inlined]
 [16] ODEFunction
    @ D:\Julia\Julia-1.10.0\packages\packages\SciMLBase\NjslX\src\scimlfunctions.jl:2184 [inlined]
 [17] initialize!(integrator::OrdinaryDiffEq.ODEIntegrator{…}, cache::OrdinaryDiffEq.Tsit5Cache{…})
    @ OrdinaryDiffEq D:\Julia\Julia-1.10.0\packages\packages\OrdinaryDiffEq\ZbQoo\src\perform_step\low_order_rk_perform_step.jl:799
 [18] __init(prob::ODEProblem{…}, alg::Tsit5{…}, timeseries_init::Tuple{}, ts_init::Tuple{}, ks_init::Tuple{}, recompile::Type{…}; saveat::StepRangeLen{…}, tstops::Tuple{}, d_discontinuities::Tuple{}, save_idxs::Nothing, save_everystep::Bool, save_on::Bool, save_start::Bool, save_end::Nothing, callback::Nothing, dense::Bool, calck::Bool, dt::Float64, dtmin::Float64, dtmax::Float64, force_dtmin::Bool, adaptive::Bool, gamma::Rational{…}, abstol::Nothing, reltol::Nothing, qmin::Rational{…}, qmax::Int64, qsteady_min::Int64, qsteady_max::Int64, beta1::Nothing, beta2::Nothing, qoldinit::Rational{…}, controller::Nothing, fullnormalize::Bool, failfactor::Int64, maxiters::Int64, internalnorm::typeof(DiffEqBase.ODE_DEFAULT_NORM), internalopnorm::typeof(LinearAlgebra.opnorm), isoutofdomain::typeof(DiffEqBase.ODE_DEFAULT_ISOUTOFDOMAIN), unstable_check::typeof(DiffEqBase.ODE_DEFAULT_UNSTABLE_CHECK), verbose::Bool, timeseries_errors::Bool, dense_errors::Bool, advance_to_tstop::Bool, stop_at_next_tstop::Bool, initialize_save::Bool, progress::Bool, progress_steps::Int64, progress_name::String, progress_message::typeof(DiffEqBase.ODE_DEFAULT_PROG_MESSAGE), progress_id::Symbol, userdata::Nothing, allow_extrapolation::Bool, initialize_integrator::Bool, alias_u0::Bool, alias_du0::Bool, initializealg::OrdinaryDiffEq.DefaultInit, kwargs::@Kwargs{})
    @ OrdinaryDiffEq D:\Julia\Julia-1.10.0\packages\packages\OrdinaryDiffEq\ZbQoo\src\solve.jl:518
 [19] __init (repeats 5 times)
    @ D:\Julia\Julia-1.10.0\packages\packages\OrdinaryDiffEq\ZbQoo\src\solve.jl:11 [inlined]
 [20] #__solve#761
    @ D:\Julia\Julia-1.10.0\packages\packages\OrdinaryDiffEq\ZbQoo\src\solve.jl:6 [inlined]
 [21] __solve
    @ D:\Julia\Julia-1.10.0\packages\packages\OrdinaryDiffEq\ZbQoo\src\solve.jl:1 [inlined]
 [22] solve_call(_prob::Any, args::Vararg{Any}; merge_callbacks::Any, kwargshandle::Any, kwargs...)
    @ DiffEqBase D:\Julia\Julia-1.10.0\packages\packages\DiffEqBase\O8cUq\src\solve.jl:612 [inlined]
 [23] solve_call
    @ D:\Julia\Julia-1.10.0\packages\packages\DiffEqBase\O8cUq\src\solve.jl:569 [inlined]
 [24] solve_up(prob::ODEProblem{…}, sensealg::Nothing, u0::Vector{…}, p::ModelingToolkit.MTKParameters{…}, args::Tsit5{…}; kwargs::@Kwargs{…})
    @ DiffEqBase D:\Julia\Julia-1.10.0\packages\packages\DiffEqBase\O8cUq\src\solve.jl:1080
 [25] solve_up
    @ DiffEqBase D:\Julia\Julia-1.10.0\packages\packages\DiffEqBase\O8cUq\src\solve.jl:1066 [inlined]
 [26] #solve#51
    @ DiffEqBase D:\Julia\Julia-1.10.0\packages\packages\DiffEqBase\O8cUq\src\solve.jl:1003 [inlined]
 [27] top-level scope
    @ e:\JlCode\DeepFlex.jl\test\pkgs\test_opt.jl:20
Some type information was truncated. Use `show(err)` to see complete types.

However, when I call @register_symbolic itp_func(t) in advance, the above problem does not exist, but in version v9.9.0, this code is not needed.

Environment (please complete the following information):

[6e4b80f9] BenchmarkTools v1.5.0
⌃ [336ed68f] CSV v0.10.13
  [b0b7db55] ComponentArrays v0.15.11
  [a93c6f00] DataFrames v1.6.1
  [82cc6244] DataInterpolations v4.7.2
  [aae7a2af] DiffEqFlux v3.4.0
  [587475ba] Flux v0.14.15
⌃ [86223c79] Graphs v1.9.0
⌃ [b2108857] Lux v0.5.31
  [bb33d45b] LuxCore v0.1.14
  [626554b9] MetaGraphs v0.7.2
  [961ee093] ModelingToolkit v9.12.0
⌃ [16a59e39] ModelingToolkitStandardLibrary v2.6.0
  [d9ec5142] NamedTupleTools v0.14.3
⌃ [8913a72c] NonlinearSolve v3.9.1
  [7f7a1694] Optimization v3.24.3
  [3e6eede4] OptimizationBBO v0.2.1
  [36348300] OptimizationOptimJL v0.2.3
  [42dfb2eb] OptimizationOptimisers v0.2.1
  [1dea7af3] OrdinaryDiffEq v6.74.1
  [7e49a35a] RuntimeGeneratedFunctions v0.5.13
  [53ae85a6] SciMLStructures v1.1.0
  [2efcf032] SymbolicIndexingInterface v0.3.16
⌃ [0c5d862f] Symbolics v5.27.1
  [e88e6eb3] Zygote v0.6.69
  [9a3f8284] Random
  [10745b16] Statistics v1.10.0
  [fa267f1f] TOML v1.0.3
Julia Version 1.10.0
Commit 3120989f39 (2023-12-25 18:01 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: 24 × 12th Gen Intel(R) Core(TM) i9-12900HX
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, alderlake)
  Threads: 1 on 24 virtual cores
Environment:
  JULIA_DEPOT_PATH = D:\Julia\Julia-1.10.0\packages
  JULIA_PKG_SERVER = https://mirrors.pku.edu.cn/julia/
  JULIA_EDITOR = code
  JULIA_NUM_THREADS = 0

Additional context

Add any other context about the problem here.

ChrisRackauckas commented 2 months ago

I cannot reproduce on latest:

(@v1.10) pkg> st
Status `~/.julia/environments/v1.10/Project.toml`
  [82cc6244] DataInterpolations v4.7.2
  [98e50ef6] JuliaFormatter v1.0.56
  [961ee093] ModelingToolkit v9.12.1
  [1dea7af3] OrdinaryDiffEq v6.74.1

(@v1.10) pkg> st -m Symbolics
Status `~/.julia/environments/v1.10/Manifest.toml`
  [0c5d862f] Symbolics v5.28.0

It's almost certainly because your Symbolics is old.

SebastianM-C commented 2 months ago

Something strange might be going on here. I can reproduce with

(jl_OM0KBh) pkg> st
Status `/tmp/jl_OM0KBh/Project.toml`
  [82cc6244] DataInterpolations v4.7.2
  [961ee093] ModelingToolkit v9.12.1
  [16a59e39] ModelingToolkitStandardLibrary v2.7.0
  [1dea7af3] OrdinaryDiffEq v6.74.1

and

(jl_OM0KBh) pkg> st -m
Status `/tmp/jl_OM0KBh/Manifest.toml`
⌅ [47edcb42] ADTypes v0.2.7
  [1520ce14] AbstractTrees v0.4.5
  [7d9f7c33] Accessors v0.1.36
  [79e6a3ab] Adapt v4.0.4
  [66dad0bd] AliasTables v1.0.0
  [ec485272] ArnoldiMethod v0.4.0
  [4fba245c] ArrayInterface v7.10.0
  [4c555306] ArrayLayouts v1.9.2
  [e2ed5e7c] Bijections v0.1.6
  [62783981] BitTwiddlingConvenienceFunctions v0.1.5
  [2a0fbf3d] CPUSummary v0.2.4
  [00ebfdb7] CSTParser v3.4.3
  [49dc2e85] Calculus v0.5.1
  [d360d2e6] ChainRulesCore v1.23.0
  [fb6a15b2] CloseOpenIntervals v0.1.12
  [861a8166] Combinatorics v1.0.2
  [a80b9123] CommonMark v0.8.12
  [38540f10] CommonSolve v0.2.4
  [bbf7d656] CommonSubexpressions v0.3.0
  [34da2185] Compat v4.14.0
  [b152e2b5] CompositeTypes v0.1.4
  [a33af91c] CompositionsBase v0.1.2
  [2569d6c7] ConcreteStructs v0.2.3
  [187b0558] ConstructionBase v1.5.5
  [adafc99b] CpuId v0.3.1
  [a8cc5b0e] Crayons v4.1.1
  [9a962f9c] DataAPI v1.16.0
  [82cc6244] DataInterpolations v4.7.2
  [864edb3b] DataStructures v0.18.20
  [e2d170a0] DataValueInterfaces v1.0.0
  [2b5f629d] DiffEqBase v6.149.1
  [459566f4] DiffEqCallbacks v3.6.1
  [163ba53b] DiffResults v1.1.0
  [b552c78f] DiffRules v1.15.1
  [31c24e10] Distributions v0.25.108
  [ffbed154] DocStringExtensions v0.9.3
  [5b8099bc] DomainSets v0.7.12
  [fa6b7ba4] DualNumbers v0.6.8
  [7c1d4256] DynamicPolynomials v0.5.6
  [06fc5a27] DynamicQuantities v0.13.2
  [4e289a0a] EnumX v1.0.4
⌃ [f151be2c] EnzymeCore v0.6.6
  [d4d017d3] ExponentialUtilities v1.26.1
  [e2ba6199] ExprTools v0.1.10
  [7034ab61] FastBroadcast v0.2.8
  [9aa1b823] FastClosures v0.3.2
  [29a986be] FastLapackInterface v2.0.2
  [1a297f60] FillArrays v1.10.2
  [64ca27bc] FindFirstFunctions v1.2.0
  [6a86dc24] FiniteDiff v2.23.1
  [1fa38f19] Format v1.3.7
  [f6369f11] ForwardDiff v0.10.36
  [069b7b12] FunctionWrappers v1.1.3
  [77dc65aa] FunctionWrappersWrappers v0.1.3
  [d9f16b24] Functors v0.4.10
  [46192b85] GPUArraysCore v0.1.6
  [c145ed77] GenericSchur v0.5.4
  [c27321d9] Glob v1.3.1
  [86223c79] Graphs v1.10.0
  [3e5b6fbb] HostCPUFeatures v0.1.16
  [34004b35] HypergeometricFunctions v0.3.23
  [615f187c] IfElse v0.1.1
  [d25df0c9] Inflate v0.1.4
  [8197267c] IntervalSets v0.7.10
  [3587e190] InverseFunctions v0.1.14
  [92d709cd] IrrationalConstants v0.2.2
  [82899510] IteratorInterfaceExtensions v1.0.0
  [692b3bcd] JLLWrappers v1.5.0
  [682c06a0] JSON v0.21.4
  [98e50ef6] JuliaFormatter v1.0.56
  [ccbc3e58] JumpProcesses v9.11.1
  [ef3ab10e] KLU v0.6.0
  [ba0b0d4f] Krylov v0.9.5
  [b964fa9f] LaTeXStrings v1.3.1
  [2ee39098] LabelledArrays v1.15.1
  [984bce1d] LambertW v0.4.6
  [23fbe1c1] Latexify v0.16.3
  [10f19ff3] LayoutPointers v0.1.15
  [5078a376] LazyArrays v1.10.0
  [d3d80556] LineSearches v7.2.0
  [7ed4a6bd] LinearSolve v2.29.0
  [2ab3a3ac] LogExpFunctions v0.3.27
  [bdcacae8] LoopVectorization v0.12.169
  [d8e11817] MLStyle v0.4.17
  [1914dd2f] MacroTools v0.5.13
  [d125e4d3] ManualMemory v0.1.8
  [a3b82374] MatrixFactorizations v2.2.0
  [bb5d69b7] MaybeInplace v0.1.2
  [e1d29d7a] Missings v1.2.0
  [961ee093] ModelingToolkit v9.12.1
  [16a59e39] ModelingToolkitStandardLibrary v2.7.0
  [46d2c3a1] MuladdMacro v0.2.4
  [102ac46a] MultivariatePolynomials v0.5.4
  [d8a4904e] MutableArithmetics v1.4.4
  [d41bc354] NLSolversBase v7.8.3
  [77ba4419] NaNMath v1.0.2
  [8913a72c] NonlinearSolve v3.10.0
  [6fe1bfb0] OffsetArrays v1.14.0
  [bac558e1] OrderedCollections v1.6.3
  [1dea7af3] OrdinaryDiffEq v6.74.1
  [90014a1f] PDMats v0.11.31
  [65ce6f38] PackageExtensionCompat v1.0.2
  [d96e819e] Parameters v0.12.3
  [69de0a69] Parsers v2.8.1
  [e409e4f3] PoissonRandom v0.4.4
  [f517fe37] Polyester v0.7.13
  [1d0040c9] PolyesterWeave v0.2.1
  [d236fae5] PreallocationTools v0.4.21
  [aea7be01] PrecompileTools v1.2.1
  [21216c6a] Preferences v1.4.3
  [08abe8d2] PrettyTables v2.3.1
  [1fd47b50] QuadGK v2.9.4
  [e6cf234a] RandomNumbers v1.5.3
  [3cdcf5f2] RecipesBase v1.3.4
  [731186ca] RecursiveArrayTools v3.13.0
  [f2c3362d] RecursiveFactorization v0.2.23
  [189a3867] Reexport v1.2.2
  [ae029012] Requires v1.3.0
  [79098fc4] Rmath v0.7.1
  [7e49a35a] RuntimeGeneratedFunctions v0.5.13
  [94e857df] SIMDTypes v0.1.0
  [476501e8] SLEEFPirates v0.6.42
  [0bca4576] SciMLBase v2.35.0
  [c0aeaf25] SciMLOperators v0.3.8
  [53ae85a6] SciMLStructures v1.1.0
  [efcf1570] Setfield v1.1.1
  [727e6d20] SimpleNonlinearSolve v1.7.0
  [699a6c99] SimpleTraits v0.9.4
  [ce78b400] SimpleUnPack v1.1.0
  [a2af1166] SortingAlgorithms v1.2.1
⌃ [47a9eef4] SparseDiffTools v2.18.0
  [e56a9233] Sparspak v0.3.9
  [276daf66] SpecialFunctions v2.3.1
  [aedffcd0] Static v0.8.10
  [0d7ed370] StaticArrayInterface v1.5.0
  [90137ffa] StaticArrays v1.9.3
  [1e83bf80] StaticArraysCore v1.4.2
  [82ae8749] StatsAPI v1.7.0
  [2913bbd2] StatsBase v0.34.3
  [4c63d2b9] StatsFuns v1.3.1
  [7792a7ef] StrideArraysCore v0.5.6
  [892a3eda] StringManipulation v0.3.4
  [2efcf032] SymbolicIndexingInterface v0.3.16
  [19f23fe9] SymbolicLimits v0.2.0
  [d1185830] SymbolicUtils v1.5.1
  [0c5d862f] Symbolics v5.28.0
  [3783bdb8] TableTraits v1.0.1
  [bd369af6] Tables v1.11.1
  [8290d209] ThreadingUtilities v0.5.2
  [a759f4b9] TimerOutputs v0.5.23
  [0796e94c] Tokenize v0.5.29
  [d5829a12] TriangularSolve v0.2.0
  [410a4b4d] Tricks v0.1.8
  [781d530d] TruncatedStacktraces v1.4.0
  [5c2747f8] URIs v1.5.1
  [3a884ed6] UnPack v1.0.2
  [1986cc42] Unitful v1.19.0
  [a7c27f48] Unityper v0.1.6
  [3d5dd08c] VectorizationBase v0.21.66
  [19fa3120] VertexSafeGraphs v0.2.0
  [1d5cc7b8] IntelOpenMP_jll v2024.1.0+0
  [856f044c] MKL_jll v2024.1.0+0
  [efe28fd5] OpenSpecFun_jll v0.5.5+0
  [f50d1b31] Rmath_jll v0.4.0+0
  [1317d2d5] oneTBB_jll v2021.12.0+0
  [0dad84c5] ArgTools v1.1.1
  [56f22d72] Artifacts
  [2a0f44e3] Base64
  [ade2ca70] Dates
  [8ba89e20] Distributed
  [f43a241f] Downloads v1.6.0
  [7b1f6079] FileWatching
  [9fa8497b] Future
  [b77e0a4c] InteractiveUtils
  [4af54fe1] LazyArtifacts
  [b27032c2] LibCURL v0.6.4
  [76f85450] LibGit2
  [8f399da3] Libdl
  [37e2e46d] LinearAlgebra
  [56ddb016] Logging
  [d6f4376e] Markdown
  [a63ad114] Mmap
  [ca575930] NetworkOptions v1.2.0
  [44cfe95a] Pkg v1.10.0
  [de0858da] Printf
  [3fa0cd96] REPL
  [9a3f8284] Random
  [ea8e919c] SHA v0.7.0
  [9e88b42a] Serialization
  [1a1011a3] SharedArrays
  [6462fe0b] Sockets
  [2f01184e] SparseArrays v1.10.0
  [10745b16] Statistics v1.10.0
  [4607b0f0] SuiteSparse
  [fa267f1f] TOML v1.0.3
  [a4e569a6] Tar v1.10.0
  [8dfed614] Test
  [cf7118a7] UUIDs
  [4ec0a83e] Unicode
  [e66e0078] CompilerSupportLibraries_jll v1.1.0+0
  [deac9b47] LibCURL_jll v8.4.0+0
  [e37daf67] LibGit2_jll v1.6.4+0
  [29816b5a] LibSSH2_jll v1.11.0+1
  [c8ffd9c3] MbedTLS_jll v2.28.2+1
  [14a3606d] MozillaCACerts_jll v2023.1.10
  [4536629a] OpenBLAS_jll v0.3.23+4
  [05823500] OpenLibm_jll v0.8.1+2
  [bea87d4a] SuiteSparse_jll v7.2.1+1
  [83775a58] Zlib_jll v1.2.13+1
  [8e850b90] libblastrampoline_jll v5.8.0+1
  [8e850ede] nghttp2_jll v1.52.0+1
  [3f19e933] p7zip_jll v17.4.0+2
Info Packages marked with ⌃ and ⌅ have new versions available. Those with ⌃ may be upgradable, but those with ⌅ are restricted by compatibility constraints from upgrading. To see why use `status --outdated -m`

for completeness I also have this in my default env

(@v1.10) pkg> st
Status `~/.julia/environments/v1.10/Project.toml`
  [4c88cf16] Aqua v0.8.7
  [6e4b80f9] BenchmarkTools v1.5.0
  [f68482b8] Cthulhu v2.12.4
  [7d51a73a] ExplicitImports v1.4.2
  [c3a54625] JET v0.8.29
  [4722fa14] PkgAuthentication v2.0.3
  [1bc83da4] SafeTestsets v0.1.0
  [aa65fe97] SnoopCompile v2.10.8

version info

Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 32 × Intel(R) Core(TM) i9-14900K
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, goldmont)
Threads: 1 default, 0 interactive, 1 GC (on 32 virtual cores)
ChrisRackauckas commented 2 months ago

@AayushSabharwal is this something to do with the move of nameof to SII?

AayushSabharwal commented 2 months ago

nameof wasn't moved to SII, it's in Base. getname was moved, but that hasn't been touched in ages so this should've broken on 8.74 if that was the issue. eqs is weird:

2-element Vector{Equation}:
 Differential(t)(x(t)) ~ [0.15048192664919013, 0.9664555481118475, 0.9970834619971073, 0.41959598059280945, 0.8543503861204015, 0.7728967286276465, 0.20186952982017736, 0.8326247812796131, 0.081629573754046, 0.5536630046205353  …  91, 92, 93, 94, 95, 96, 97, 98, 99, 100](t) + x(t)*(α - y(t)*β)
 Differential(t)(y(t)) ~ [0.060200107278550186, 0.21248632701673442, 0.31347491400392635, 0.9002263713913606, 0.6238630260261939, 0.2163621045540277, 0.6347136437519222, 0.17954756274269623, 0.07287984842803796, 0.7260284869591382  …  91, 92, 93, 94, 95, 96, 97, 98, 99, 100](t) + (-γ + x(t)*δ)*y(t)

An array followed by (t) is weird. Makes me think this is array-variable related

AayushSabharwal commented 2 months ago

Hm I'm still not sure how this even works in the old version.

Codegen in 9.9:

julia> odeprob.f.f.f_iip
RuntimeGeneratedFunction(#=in ModelingToolkit=#, #=using ModelingToolkit=#, :((ˍ₋out, ˍ₋arg1, ˍ₋arg2, t)->begin
          #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:373 =#
          #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:374 =#
          #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:375 =#
          begin
              begin
                  begin
                      #= /Users/aayush/.julia/packages/Symbolics/Eas9m/src/build_function.jl:546 =#
                      #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:422 =# @inbounds begin
                              #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:418 =#
                              ˍ₋out[1] = (+)(([0.11188588946792466, 0.2305769462101478, 0.691785808918783, 0.2960175761233672, 0.751250904720803, 1, 2, 3, 4, 5])(t), (*)(ˍ₋arg1[1], (+)(ˍ₋arg2[1], (*)((*)(-1, ˍ₋arg1[2]), ˍ₋arg2[2]))))
                              ˍ₋out[2] = (+)(([0.48881115597432456, 0.14915082300365756, 0.6130798328244379, 0.9954947737717248, 0.6674729550162395, 1, 2, 3, 4, 5])(t), (*)((+)((*)(-1, ˍ₋arg2[4]), (*)(ˍ₋arg1[1], ˍ₋arg2[3])), ˍ₋arg1[2]))
                              #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:420 =#
                              nothing
                          end
                  end
              end
          end
      end))

Codegen in 9.12:

julia> odeprob.f.f.f_iip
RuntimeGeneratedFunction(#=in ModelingToolkit=#, #=using ModelingToolkit=#, :((ˍ₋out, ˍ₋arg1, ˍ₋arg2, t)->begin
          #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:373 =#
          #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:374 =#
          #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:375 =#
          begin
              begin
                  begin
                      #= /Users/aayush/.julia/packages/Symbolics/Eas9m/src/build_function.jl:546 =#
                      #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:422 =# @inbounds begin
                              #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:418 =#
                              ˍ₋out[1] = (+)((Real[0.6043104225792177, 0.8909446317822332, 0.7634698087557004, 0.09017826537509666, 0.1089880835700695, 1, 2, 3, 4, 5])(t), (*)(ˍ₋arg1[1], (+)(ˍ₋arg2[1], (*)((*)(-1, ˍ₋arg1[2]), ˍ₋arg2[2]))))
                              ˍ₋out[2] = (+)((Real[0.4191547702848576, 0.6490597699519044, 0.052732190476225016, 0.0020463945402650063, 0.7585135795160668, 1, 2, 3, 4, 5])(t), (*)((+)((*)(-1, ˍ₋arg2[4]), (*)(ˍ₋arg1[1], ˍ₋arg2[3])), ˍ₋arg1[2]))
                              #= /Users/aayush/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:420 =#
                              nothing
                          end
                  end
              end
          end
      end))

I used a smaller interpolation object. In both cases the generated code calls an array, which shouldn't work. It's not going to be correct for the case that works either, since you want to call the interpolation object and not the array.

AayushSabharwal commented 2 months ago

This works if you @register_symbolic itp_func(t), which I'd argue is the correct way to do it. @register_symbolic (::DataInterpolations.AbstractInterpolation)(t) doesn't work, which is a separate issue (the generated code doesn't look right).

sathvikbhagavan commented 2 months ago

This seems to be fixed with DataInterpolations v5

(jl_w1MElV) pkg> st
Status `/tmp/jl_w1MElV/Project.toml`
  [82cc6244] DataInterpolations v5.0.0
  [961ee093] ModelingToolkit v9.12.2
  [1dea7af3] OrdinaryDiffEq v6.75.0
julia> @mtkbuild odesys = ODESystem(eqs, t)
Model odesys with 2 equations
Unknowns (2):
  x(t)
  y(t)
Parameters (4):
  α
  β
  δ
⋮
Incidence matrix:2×4 SparseArrays.SparseMatrixCSC{Num, Int64} with 6 stored entries:
 ×  ×  ×  ⋅
 ×  ×  ⋅  ×
ChrisRackauckas commented 2 months ago

Wait you didn't talk about the equations display. Again, this is an issue about display and not actual functionality of the package.

sathvikbhagavan commented 2 months ago

Not erroring in displaying equations as well

julia> equations(odesys)
2-element Vector{Equation}:
 Differential(t)(x(t)) ~ LinearInterpolation{Vector{Float64}, UnitRange{Int64}, Float64}([0.5825329623737308, 0.45838596220625605, 0.18812571717905435, 0.4080836888725168, 0.6098074396903841, 0.3406285128440162, 0.5505018498614226, 0.5784293540404422, 0.26965062948459984, 0.01533109828296364  …  0.4579465375345101, 0.3997439403158828, 0.6591374927876985, 0.06427388889480923, 0.8192446814024471, 0.38102629073055194, 0.6896326803970537, 0.47786717303661685, 0.6222903254064543, 0.4817643443687023], 1:100, true)(t) + x(t)*(α - y(t)*β)
 Differential(t)(y(t)) ~ LinearInterpolation{Vector{Float64}, UnitRange{Int64}, Float64}([0.7861306405485775, 0.2646534167882082, 0.5960709684629655, 0.264169180303755, 0.6151987343867357, 0.4104167881085147, 0.31210121720207107, 0.6602359123110422, 0.5756648803198983, 0.48472748132904575  …  0.2590303990738163, 0.9104062573004824, 0.610777443936537, 0.5591642375958834, 0.1131762136207417, 0.6418060403438048, 0.023133347883824595, 0.834148193629524, 0.6156993141493069, 0.7028156336020228], 1:100, true)(t) + (-γ + x(t)*δ)*y(t)