search

SciML / DataInterpolations.jl

A library of data interpolation and smoothing functions
MIT License
203 stars 43 forks source link

fix: get element type from `interp.u` instead of `interp` #254

Closed sathvikbhagavan closed 1 month ago

sathvikbhagavan commented 1 month ago

fixes: #253

In DataInterpolations@v4, eltype(interp) returned eltype(interp.u) as it subtyped AbstractVector of type which is the eltype of interp.u

In DataInterpolations@v5, eltype(interp) returns Any as the subtyping to AbstractVector is removed, hence the issue. Fixing it to use eltype(interp.u).

Added a few tests to ensure the returned vectors have the same type as interp.u.

sathvikbhagavan commented 1 month ago

Not sure why Symbolics.jl is failing to precompile - https://github.com/SciML/DataInterpolations.jl/actions/runs/9316593135/job/25645177538?pr=254#step:6:376

ChrisRackauckas commented 1 month ago

Depwarns are turned to errors. I'll handle this today.