update retcode from symbol

SciML / DelayDiffEq.jl

Delay differential equation (DDE) solvers in Julia for the SciML scientific machine learning ecosystem. Covers neutral and retarded delay differential equations, and differential-algebraic equations.

Other

59 stars 26 forks source link

update retcode from symbol #288

Closed kaitlyn-loftus closed 5 months ago

kaitlyn-loftus commented 5 months ago

fix terminate! to update solution's retcode with a SciMLBase.ReturnCode instead of a Symbol (raises warning)

Checklist

[X] Appropriate tests were added
[X] Any code changes were done in a way that does not break public API
[X] All documentation related to code changes were updated
[X] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[X] Any new documentation only uses public API

Additional context

Followed what's in OrdinaryDiffEq.jl

kaitlyn-loftus commented 5 months ago

I'm not sure @devmotion. The warning is from here.