search

SciML / DiffEqBase.jl

The lightweight Base library for shared types and functionality for defining differential equation and scientific machine learning (SciML) problems
Other
302 stars 106 forks source link

Incorrect ordering of promotion #1030

Closed avik-pal closed 2 months ago

avik-pal commented 2 months ago

If p is not extracted before, then it tries to promote u0 to the tracked type.

avik-pal commented 2 months ago

@ChrisRackauckas the test failure is real https://github.com/SciML/DiffEqBase.jl/actions/runs/9069483730/job/24919132493#step:6:1967. We need to figure out how to do the conversion in a device agnostic way but convert(AbstractArray, ...) doesnt seem to work

ChrisRackauckas commented 2 months ago

oh oops. Use Adapt?

avik-pal commented 2 months ago

does Adapt natively work with RAT? I don't see any code there for that.

We should probably overload convert(AbstractArray, <RAT>) instead of https://github.com/SciML/RecursiveArrayTools.jl/blob/39573324b1460a8cefeed7dbb2a85350713544d4/src/vector_of_array.jl#L130

ChrisRackauckas commented 2 months ago

that would be good to add