search

SciML / DiffEqBase.jl

The lightweight Base library for shared types and functionality for defining differential equation and scientific machine learning (SciML) problems
Other
302 stars 106 forks source link

Don't check for large values in the unstable check #1035

Closed oscardssmith closed 2 months ago

oscardssmith commented 2 months ago

Fixes regression for Float32 ODEs caused by https://github.com/SciML/DiffEqBase.jl/pull/1033. This check in general doesn't really do much, and I think we probably will switch it to just be return false eventually, but first we need to add something to OrdinaryDiffEq.jl that actually checks for divergence in a more useful way (e.g. tracking number of failed steps in a row).

oscardssmith commented 2 months ago

We actually did this yesterday (oops)