search

SciML / DiffEqBase.jl

The lightweight Base library for shared types and functionality for defining differential equation and scientific machine learning (SciML) problems
Other
311 stars 111 forks source link

Revert "use Enzyme make_zero" #1055

Closed ChrisRackauckas closed 4 months ago

ChrisRackauckas commented 4 months ago

Reverts SciML/DiffEqBase.jl#1054 @wsmoses @m-bossart

wsmoses commented 4 months ago

FWIW you can still (and should) keep the change to replace deep-copy and broadcast in the fwd pass with make zero, the reverse pass broadcast tho is the part that would cause issues