search

SciML / DiffEqBase.jl

The lightweight Base library for shared types and functionality for defining differential equation and scientific machine learning (SciML) problems
Other
302 stars 106 forks source link

make `ODE_DEFAULT_UNSTABLE_CHECK` just return false #1056

Closed oscardssmith closed 1 month ago

oscardssmith commented 1 month ago

Since https://github.com/SciML/SciMLBase.jl/pull/693 the instability check is only triggered on accepted steps, so we can save some time and just never return unstable by default.

oscardssmith commented 1 month ago

interesting. The test failure suggests that we do sometimes accept a step of size Inf. not sure how that's possible.