Open ArnoStrouwen opened 6 months ago
That is correct. sol[88]
and sol[end]
are what are deprecated.
88 is the end. Yet the result is not the same.
I see what's going on here.
┌ Warning:
Base.getindex(A::AbstractDiffEqArray, i::Int)
is deprecated, useBase.getindex(A, :, i)
instead. │ caller = top-level scope at REPL[27]:1 └ @ Core REPL[27]:1
That depwarn is just wrong because A.u[end]
is not a vector. sol[:,end]
should give a boundserror @AayushSabharwal
That's a bit of a tricky one. sol[:, end]
lowers to sol[:, lastindex(sol, 2)]
. Are we sure no one uses lastindex(sol, i)
?
How indexing works for VoA is
sol[x]
: deprecated, falls back to sol.u[:, x]
sol[<all colons>]
turns sol
into an Array
sol[x::CartesianIndex]
uses the last index in x
for sol.u
and the rest for sol.u[first(x)]
sol[x::AnythingElse...]
uses the last index in x
for sol.u
and the rest for sol.u[first(x)]
However lastindex(VA, d) = last(axes(VA, d))
so it looks like VA[:, end]
doesn't really work when the subarrays aren't vectors. We could just update the depwarn to tell people to use as many Colon()
s as dims - 1
This one can probably get updated?
RAT deprecation message is incorrect here for the manifold tests.