search

SciML / DiffEqCallbacks.jl

A library of useful callbacks for hybrid scientific machine learning (SciML) with augmented differential equation solvers
https://docs.sciml.ai/DiffEqCallbacks/stable/
Other
85 stars 44 forks source link

Recent changes break PresetTimeCallbacks with pure JumpProcesses #214

Closed isaacsas closed 3 months ago

isaacsas commented 3 months ago

https://github.com/SciML/DiffEqCallbacks.jl/commit/2026bcb23a9467c460d59b3cb23ab4491092985c

assumes integrators have a dt field, which is not the case for all integrators (for example, SSAStepper in JumpProcesses). This means that PresetTimeCallbacks no longer work with such problems, and is causing tests to fail in other packages now, for example MTK: https://github.com/SciML/ModelingToolkit.jl/actions/runs/8507457864/job/23299357875#step:6:1028

isaacsas commented 3 months ago

Ahh, didn't see this is now fixed in https://github.com/SciML/DiffEqCallbacks.jl/pull/213 so closing.