SciML / DiffEqDocs.jl

Documentation for the DiffEq differential equations and scientific machine learning (SciML) ecosystem
https://docs.sciml.ai/DiffEqDocs/stable/
Other
273 stars 242 forks source link

@ode_def_nohes macro replaced by @ode_def_all? #192

Closed SuperFluffy closed 5 years ago

SuperFluffy commented 5 years ago

The tutorial on Uncertainty quantification mentions the macro @ode_def_nohes. It looks like this is an artifact from the past? ParameterizedFunctions.jl does not mention that macro anymore, it looks like it was removed in commit d525ac12334a210f08d0224290cdfc51ae2101cd. The macro @ode_def_all seems to be a direct replacement?

If that's the case, I can make a PR for the docs. I am technically only using Julia since Wednesday, so I can't make an educated decision.

ChrisRackauckas commented 5 years ago

Yeah, it's an artifact of the past. Standard @ode_def works, though we should definitely try using only "standard" ODE definitions as much as possible.

ChrisRackauckas commented 5 years ago

This has been all updated.