search

SciML / DiffEqGPU.jl

GPU-acceleration routines for DifferentialEquations.jl and the broader SciML scientific machine learning ecosystem
https://docs.sciml.ai/DiffEqGPU/stable/
MIT License
284 stars 29 forks source link

WIP: Mass matrix support for rosenbrock23 #280

Closed tshort closed 1 year ago

tshort commented 1 year ago

This adds support for models with a mass_matrix. For me, this is to enable usage with models generated by ModelingToolkit. Right now, these models do not solve correctly.

I've marked it as WIP because I'm new to the code and probably need feedback on tests or anything else I need to do.

tshort commented 1 year ago

i removed the WIP because I'm not currently working on any changes. That was mainly to indicate it needs a good review.

utkarsh530 commented 1 year ago

LGTM. Test failure looks unreal.

utkarsh530 commented 1 year ago

Can you format your code?

using JuliaFormatter
format(".")
ChrisRackauckas commented 1 year ago

The test failures look pretty real. I'm not sure the uniform scaling kernels work on GPU.

utkarsh530 commented 1 year ago

The test failures were due to double precision values with backends other than CUDA.