SciML / DiffEqGPU.jl

GPU-acceleration routines for DifferentialEquations.jl and the broader SciML scientific machine learning ecosystem
https://docs.sciml.ai/DiffEqGPU/stable/
MIT License
285 stars 29 forks source link

test 1.4 #89

Closed ChrisRackauckas closed 3 years ago

ChrisRackauckas commented 3 years ago

v1.4 worked before: https://gitlab.com/JuliaGPU/DiffEqGPU.jl/-/jobs/905347464

Just trying to isolate the error on master.

ChrisRackauckas commented 3 years ago

@jpsamaroo @vchuravy these tests show that the failure is due to a change from Julia v1.4->v1.5.

ChrisRackauckas commented 3 years ago

Slack conversation:

Christopher Rackauckas 4 days ago https://buildkite.com/julialang/diffeqgpu-dot-jl/builds/21#c548aacb-bdbc-4a10-b0b7-7d4d6955f382

BuildkiteBuildkite DiffEqGPU.jl #21 · JuliaLang Add the pipeline.yml file for Buildkite

Julian Samaroo 4 days ago Looks like checked arithmetic is being used, which can cause an invokelatest to be emitted. I suspect that invokelatest is not allowed within kernels. @vchuravy

Christopher Rackauckas 4 days ago we're not using checked arithmetic and we wrote the kernel?

Christopher Rackauckas 4 days ago https://github.com/SciML/DiffEqGPU.jl/blob/master/src/DiffEqGPU.jl#L607-L613 https://github.com/SciML/DiffEqGPU.jl/blob/master/src/DiffEqGPU.jl#L646-L678

src/DiffEqGPU.jl:607-613 https://github.com/SciML/DiffEqGPU.jl|SciML/DiffEqGPU.jlSciML/DiffEqGPU.jl | Added by GitHub

src/DiffEqGPU.jl:646-678 https://github.com/SciML/DiffEqGPU.jl|SciML/DiffEqGPU.jlSciML/DiffEqGPU.jl | Added by GitHub

Christopher Rackauckas 4 days ago That's the whole thing.

Christopher Rackauckas 4 days ago Maybe staticarray \ changed to be incompatible with KernelAbstractions?

Julian Samaroo 4 days ago Various parts of Base use checked arithmetic, so it's not necessarily DiffEqGPU's fault

Julian Samaroo 4 days ago Specifically, ranges seem to use checked_* methods

Julian Samaroo 4 days ago Why this is showing up just now, I have no idea

Christopher Rackauckas 12 hours ago hmm is there a solution?