search

SciML / DiffEqOperators.jl

Linear operators for discretizations of differential equations and scientific machine learning (SciML)
https://docs.sciml.ai/DiffEqOperators/stable/
Other
285 stars 74 forks source link

Add aqua tests #552

Closed charleskawczynski closed 1 year ago

charleskawczynski commented 1 year ago

This PR adds some aqua tests. I'm happy to help chip away at some of the performance-related ones in subsequent PRs.

ChrisRackauckas commented 1 year ago

I'm happy to help chip away at some of the performance-related ones in subsequent PRs.

That would be greatly helpful. Though, are you still using DiffEqOperators? This library was largely obsoleted by SciMLOperators quite some time ago for most things, so I am a bit confused to see this getting some activity.

charleskawczynski commented 1 year ago

That would be greatly helpful. Though, are you still using DiffEqOperators? This library was largely obsoleted by SciMLOperators quite some time ago for most things, so I am a bit confused to see this getting some activity.

Ah, ok. We’re not using it directly, but we must be using it indirectly because I noticed some unbound arg warnings when updating dependencies

ChrisRackauckas commented 1 year ago

https://juliahub.com/ui/Packages/DiffEqOperators/Vx3Cs/4.45.0?page=2 most of the dependents that are SciML don't use it these days, so I'm not sure where it would come into a dependency tree. What's the project.toml that is associated with that?

charleskawczynski commented 1 year ago

I don’t see any of them at first glance, I’ll take a closer look when I’m at my computer next

charleskawczynski commented 1 year ago

Weird, I'm not seeing DiffEqOperators in the manifest 🤷🏻

charleskawczynski commented 1 year ago

Maybe I had an old manifest or something. I’m fine with closing if this is being deprecated