search

SciML / DiffEqPhysics.jl

A library for building differential equations arising from physical problems for physics-informed and scientific machine learning (SciML)
Other
50 stars 19 forks source link

changed default param argument to `NullParameters()` #65

Closed ExpandingMan closed 1 year ago

ExpandingMan commented 3 years ago

Some packages (in my case DiffEqGPU.jl) seem to assume that if no parameter arguments are given, the parameter type is NullParameters. Actually, I'm a little unclear about what exactly is permitted here since DiffEqGPU calls Array(prob.p), which should probably be changed anyway since this throws errors at all sorts of things.

Regardless, this change seemed appropriate and fixes that particular issue.

ChrisRackauckas commented 3 years ago

Thanks!

since DiffEqGPU calls Array(prob.p), which should probably be changed anyway since this throws errors at all sorts of things.

Yeah, it's definitely not robust.