search

SciML / DifferentialEquations.jl

Multi-language suite for high-performance solvers of differential equations and scientific machine learning (SciML) components. Ordinary differential equations (ODEs), stochastic differential equations (SDEs), delay differential equations (DDEs), differential-algebraic equations (DAEs), and more in Julia.
https://docs.sciml.ai/DiffEqDocs/stable/
Other
2.8k stars 222 forks source link

Fix typo in ODE algorithms: Use FBDF for problems with > 50 states #1024

Closed devmotion closed 2 months ago

devmotion commented 2 months ago

There are two identical conditions length(prob.u0) > 500 in a single if - elseif - ... statement, so the second one is never hit. Based on the branches for problems with :auto hints below and the logic prior to https://github.com/SciML/DifferentialEquations.jl/pull/977, I assume that the second condition was introduced accidentally in https://github.com/SciML/DifferentialEquations.jl/pull/977 and was supposed to be length(prob.u0) > 50.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.43%. Comparing base (8ce23d2) to head (b097bfd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1024 +/- ## ======================================= Coverage 85.43% 85.43% ======================================= Files 11 11 Lines 151 151 ======================================= Hits 129 129 Misses 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.