SciML / DifferentialEquations.jl

Multi-language suite for high-performance solvers of differential equations and scientific machine learning (SciML) components. Ordinary differential equations (ODEs), stochastic differential equations (SDEs), delay differential equations (DDEs), differential-algebraic equations (DAEs), and more in Julia.
https://docs.sciml.ai/DiffEqDocs/stable/
Other
2.82k stars 222 forks source link

Add parameter field for CVODE_BDF integrator #253

Closed TorkelE closed 6 years ago

TorkelE commented 6 years ago

Might be talking about things of which I do not know so much. However, the integrator for the CVODE_BDF solver for ordinary Differential Equations do not have a field p, which means that you can not access the parameters of the problem if you are using this specific solver (unlike some other solvers). This can be used by e.g. callbacks modifying parameter values. As I've said there might be a good reason for this, just raising the issue if that is not the case.

ChrisRackauckas commented 6 years ago

https://github.com/JuliaDiffEq/Sundials.jl/issues/153 I (or someone else) just need to get around to it. It's not particularly difficult though, and for now integrator.sol.prob.p works.

ChrisRackauckas commented 6 years ago

https://github.com/JuliaDiffEq/Sundials.jl/commit/b6bc35770cbeacb77de57a3a5e9e4e71860fbe51