ChrisRackauckas
commented
8 months ago I pushed it along and got pretty far:
using DynamicQuantities, OrdinaryDiffEq, RecursiveArrayTools
function RecursiveArrayTools.recursive_unitless_bottom_eltype(a::Type{
<:DynamicQuantities.Quantity{T}
}) where T
T
end
function RecursiveArrayTools.recursive_unitless_eltype(a::Type{<:DynamicQuantities.Quantity{T}}) where T
T
end
DiffEqBase.value(x::DynamicQuantities.Quantity) = x.value
@inline function DiffEqBase.UNITLESS_ABS2(x::AbstractArray)
mapreduce(DiffEqBase.UNITLESS_ABS2, DiffEqBase.abs2_and_sum, x, init = zero(real(first(DiffEqBase.value(x)))))
end
@inline function DiffEqBase.UNITLESS_ABS2(x::DynamicQuantities.Quantity)
abs(DiffEqBase.value(x))
end
function DiffEqBase.abs2_and_sum(x::DynamicQuantities.Quantity, y::Float64)
reduce(Base.add_sum, DiffEqBase.value(x), init = zero(real(DiffEqBase.value(x)))) +
reduce(Base.add_sum, y, init = zero(real(DiffEqBase.value(eltype(y)))))
end
DiffEqBase.recursive_length(u::Array) = length(u)
Base.sign(x::DynamicQuantities.Quantity) = Base.sign(DiffEqBase.value(x))
function DiffEqBase.prob2dtmin(prob; use_end_time = true)
DiffEqBase.prob2dtmin(prob.tspan, oneunit(first(prob.tspan)), use_end_time)
end
DiffEqBase.NAN_CHECK(x::DynamicQuantities.Quantity) = isnan(x)
Base.zero(x::Array{T}) where {T<:DynamicQuantities.Quantity} = zero.(x)
@inline function DiffEqBase.calculate_residuals(ũ, u₀, u₁, α, ρ, internalnorm, t)
@. DiffEqBase.calculate_residuals(ũ, u₀, u₁, α, ρ, internalnorm, t)
end
f(u, p, t) = u / t;
problem = ODEProblem(f, [1.0u"km/s"], (0.0u"s", 1.0u"s"));
sol = solve(problem, Tsit5(), dt = 0.1u"s")with just one internal modification. Two interface breaks are weird though:
First one:
julia> typeof(one(0.0u"s"))
Quantity{Float64, Dimensions{DynamicQuantities.FixedRational{Int32, 25200}}}that should just be Float64?
Second there's something odd in brodcasting I haven't isolated yet.
MilesCranmer
Trying out a DynamicQuantities.jl example with DifferentialEquations.jl but running into some issues with the use of
oneunit(::Type{T})rather thanoneunit(::T). I think changing to the latter will make things compatible with both DynamicQuantities and Unitful.