search

SciML / EasyModelAnalysis.jl

High level functions for analyzing the output of simulations
MIT License
79 stars 13 forks source link

WIP: Expose solve's keyword arguments in datafit #173

Closed joshday closed 1 year ago

joshday commented 1 year ago

I think I'm missing some context as to what Chris is describing in his comment, but I believe this fixes/enables https://github.com/SciML/EasyModelAnalysis.jl/issues/158.

I'll update the docs if maintainers think this is an agreeable change.

anandijain commented 1 year ago

https://github.com/SciML/EasyModelAnalysis.jl/pull/172/files#diff-a823f2cccdf50aeada25e1047fd0e077a6500fc86cb107ffd3085ebf9a09a561R49 I did this in here too. I think that PR is good to merge. There was some doc failures, but the tests passed

joshday commented 1 year ago

Ah okay, I missed that! I'll close this then.