search

SciML / EasyModelAnalysis.jl

High level functions for analyzing the output of simulations
MIT License
81 stars 14 forks source link

Expose solve kws to datafit functions. #215

Closed jClugstor closed 1 year ago

jClugstor commented 1 year ago

Users of datafit can pass keyword args to the solver for the OptimizationProblem. Standard l2loss function returns the solution along with the total loss so that callbacks to the solver can use the solution.

codecov[bot] commented 1 year ago

Codecov Report

Merging #215 (ca8e281) into main (6b7ae5b) will increase coverage by 38.25%. The diff coverage is 83.33%.

@@             Coverage Diff             @@
##             main     #215       +/-   ##
===========================================
+ Coverage   53.77%   92.02%   +38.25%     
===========================================
  Files           7        7               
  Lines         437      439        +2     
===========================================
+ Hits          235      404      +169     
+ Misses        202       35      -167
Files Coverage Δ
src/datafit.jl 80.15% <83.33%> (+54.35%) :arrow_up:

... and 5 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ChrisRackauckas commented 1 year ago

tests fail

jClugstor commented 1 year ago

These should fix the ensemble tests and make the datafit tests run.