search

SciML / EasyModelAnalysis.jl

High level functions for analyzing the output of simulations
MIT License
79 stars 13 forks source link

try updating #243

Closed ChrisRackauckas closed 5 months ago

jClugstor commented 6 months ago

It looks like a few tests are erroring after updating, not just in datafit. One Sensitivity, one Ensemble, and one Threshold test all fail when tested locally.

jClugstor commented 6 months ago

In _get_sensitivity there's a line prob_func(prob, i, repeat) = remake(prob; p = Pair.(boundkeys, p[:, i])) does the remake still make sense with the update to MTK handling of parameters? The error is related to the initial conditions, maybe we need to supply the default initial conditions to the remake?

It can be fixed by adding σ => [28.0, 28.0] to the pbounds, but I'd guess that one of the points of the test is to not check the sensitivity of σ ?

ChrisRackauckas commented 5 months ago

It does not, it needs to use the SciMLStructures canonicalization

jClugstor commented 5 months ago

Basically I just need to change it to use something like this https://docs.sciml.ai/ModelingToolkit/dev/examples/remake/#remake-and-setp/setu instead?

ChrisRackauckas commented 5 months ago

Yes